Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2151)

Issue 2131883002: Clear SSLClientSessionCache on low memory notifications. (Closed)

Created:
4 years, 5 months ago by maksims (do not use this acc)
Modified:
4 years, 5 months ago
Reviewers:
asanka, davidben, Maria, mmenke
CC:
cbentzel+watch_chromium.org, chromium-reviews, Maria
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear SSLClientSessionCache on low memory notifications. There are two cases when cache is flushed: 1) MEMORY_PRESSURE_LEVEL_MODERATE: flush expired sessions only. 2) MEMORY_PRESSURE_LEVEL_CRITICAL: flush everything. BUG=622069 Committed: https://crrev.com/90e6f5527236b01e687e65722b257e884fc7f1b6 Cr-Commit-Position: refs/heads/master@{#404609}

Patch Set 1 #

Patch Set 2 : rebased + removed not used method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -1 line) Patch
M net/ssl/ssl_client_session_cache.h View 1 3 chunks +8 lines, -0 lines 0 comments Download
M net/ssl/ssl_client_session_cache.cc View 2 chunks +18 lines, -1 line 0 comments Download
M net/ssl/ssl_client_session_cache_unittest.cc View 2 chunks +46 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
maksims (do not use this acc)
please review.
4 years, 5 months ago (2016-07-08 12:14:42 UTC) #3
Maria
Thanks for doing this. I'm moving myself to cc since I am not familiar with ...
4 years, 5 months ago (2016-07-08 18:21:34 UTC) #5
asanka
-> davidben@
4 years, 5 months ago (2016-07-08 18:26:21 UTC) #8
davidben
lgtm
4 years, 5 months ago (2016-07-08 18:49:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131883002/1
4 years, 5 months ago (2016-07-11 04:56:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131883002/20001
4 years, 5 months ago (2016-07-11 05:21:24 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-11 07:12:53 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 07:14:54 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/90e6f5527236b01e687e65722b257e884fc7f1b6
Cr-Commit-Position: refs/heads/master@{#404609}

Powered by Google App Engine
This is Rietveld 408576698