Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2131873002: Remove unneeded type indirections from CallbackPromiseAdapter. (Closed)

Created:
4 years, 5 months ago by e_hakkinen
Modified:
4 years, 5 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unneeded type indirections from CallbackPromiseAdapter. Now that Blink uses std::unique_ptr instead of OwnPtr, type mapping structs and using-declarations in CallbackPromiseAdapter are no-ops and can thus be removed. Committed: https://crrev.com/39a62799e3d7d69725863d324d265c06f03b6c75 Cr-Commit-Position: refs/heads/master@{#404346}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -26 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h View 3 chunks +5 lines, -26 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
e_hakkinen
PTAL.
4 years, 5 months ago (2016-07-08 09:35:21 UTC) #2
haraken
LGTM
4 years, 5 months ago (2016-07-08 10:08:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131873002/1
4 years, 5 months ago (2016-07-08 10:36:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 13:59:50 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 14:00:13 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 14:03:26 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39a62799e3d7d69725863d324d265c06f03b6c75
Cr-Commit-Position: refs/heads/master@{#404346}

Powered by Google App Engine
This is Rietveld 408576698