Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 213183003: [Telemetry] Add test case for power usage of background animations/heavy tab. (Closed)

Created:
6 years, 9 months ago by jeremy
Modified:
6 years, 8 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] Add test case for power usage of background animations/heavy tab. Add a test case for quiescent power with the following tabs open: * Animated gif (in background). * GMail * Below the fold animated gif * Below the fold flash (in foreground). BUG=339180 R=tonyg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262360

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -0 lines) Patch
M tools/perf/benchmarks/tab_switching.py View 1 1 chunk +5 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_energy_cases.json View 1 1 chunk +22 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_energy_cases/Biang-order.gif View 1 Binary file 0 comments Download
A tools/perf/page_sets/tough_energy_cases/above-fold-animated-gif.html View 1 1 chunk +9 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_energy_cases/below-fold-animated-gif.html View 1 1 chunk +11 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_energy_cases/below-fold-flash.html View 1 1 chunk +22 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_energy_cases/test.swf View 1 Binary file 0 comments Download

Messages

Total messages: 7 (0 generated)
jeremy
6 years, 9 months ago (2014-03-27 13:50:19 UTC) #1
tonyg
lgtm https://codereview.chromium.org/213183003/diff/1/tools/perf/benchmarks/tab_switching.py File tools/perf/benchmarks/tab_switching.py (right): https://codereview.chromium.org/213183003/diff/1/tools/perf/benchmarks/tab_switching.py#newcode19 tools/perf/benchmarks/tab_switching.py:19: class TabSwitchingPowerMeasurement(test.Test): Let's call this TabSwitchingToughEnergyCases. https://codereview.chromium.org/213183003/diff/1/tools/perf/page_sets/power_intensive.json File ...
6 years, 8 months ago (2014-03-31 17:16:09 UTC) #2
jeremy
The CQ bit was checked by jeremy@chromium.org
6 years, 8 months ago (2014-04-02 06:01:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/213183003/10001
6 years, 8 months ago (2014-04-02 06:01:57 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 06:31:36 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=59002
6 years, 8 months ago (2014-04-02 06:31:36 UTC) #6
jeremy
6 years, 8 months ago (2014-04-08 09:18:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r262360 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698