Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: ui/login/account_picker/user_pod_row.js

Issue 2131823004: Dialog message saying PIN is incorrect positioned correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Addressed comment. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/login/account_picker/user_pod_row.js
diff --git a/ui/login/account_picker/user_pod_row.js b/ui/login/account_picker/user_pod_row.js
index 48a7073ad110d478bd66bc14505e630c93751e20..912c21b627800894d98c375437371600261c3cf5 100644
--- a/ui/login/account_picker/user_pod_row.js
+++ b/ui/login/account_picker/user_pod_row.js
@@ -748,11 +748,6 @@ cr.define('login', function() {
this.passwordElement.addEventListener('keypress',
this.handlePasswordKeyPress_.bind(this));
- if (this.pinKeyboard) {
- this.pinKeyboard.addEventListener('submit',
- this.handlePinSubmitted_.bind(this));
- }
-
this.imageElement.addEventListener('load',
this.parentNode.handlePodImageLoad.bind(this.parentNode, this));
@@ -773,16 +768,6 @@ cr.define('login', function() {
},
/**
- * Handles the user hitting 'submit' on the PIN keyboard.
- * @param {Event} e Submit event object.
- * @private
- */
- handlePinSubmitted_: function(e) {
- var pin = e.detail.pin;
- chrome.send('authenticateUser', [this.user.username, pin]);
- },
-
- /**
* Handles keypress event (i.e. any textual input) on password input.
* @param {Event} e Keypress Event object.
* @private
@@ -1188,6 +1173,8 @@ cr.define('login', function() {
*/
get mainInput() {
if (this.isAuthTypePassword) {
+ if (this.pinContainer.classList.contains('pin-enabled'))
+ return this.pinKeyboard.inputElement;
return this.passwordElement;
} else if (this.isAuthTypeOnlineSignIn) {
return this;
@@ -1354,11 +1341,11 @@ cr.define('login', function() {
this.classList.toggle('signing-in', true);
chrome.send('attemptUnlock', [this.user.username]);
} else if (this.isAuthTypePassword) {
- if (!this.passwordElement.value)
+ var password = this.passwordElement.value || this.pinKeyboard.value;
+ if (!password)
return false;
Oobe.disableSigninUI();
- chrome.send('authenticateUser',
- [this.user.username, this.passwordElement.value]);
+ chrome.send('authenticateUser', [this.user.username, password]);
} else {
console.error('Activating user pod with invalid authentication type: ' +
this.authType);
@@ -1420,6 +1407,7 @@ cr.define('login', function() {
*/
reset: function(takeFocus) {
this.passwordElement.value = '';
+ this.pinKeyboard.value = '';
this.classList.toggle('signing-in', false);
if (takeFocus) {
if (!this.multiProfilesPolicyApplied)
@@ -1817,6 +1805,11 @@ cr.define('login', function() {
// Note that this.userClickAuthAllowed_ is set in mouse down event
// handler.
this.parentNode.setActivatedPod(this);
+ } else if (this.pinKeyboard.submitButton &&
+ e.target == this.pinKeyboard.submitButton) {
+ // Sets the pod as activated if the submit button is clicked so that
+ // it simulates what the enter button does for the password/pin.
+ this.parentNode.setActivatedPod(this);
}
if (this.multiProfilesPolicyApplied)
@@ -3413,6 +3406,7 @@ cr.define('login', function() {
if (this.focusedPod_) {
var targetTag = e.target.tagName;
if (e.target == this.focusedPod_.passwordElement ||
+ e.target == this.focusedPod_.pinKeyboard.inputElement ||
(targetTag != 'INPUT' &&
targetTag != 'BUTTON' &&
targetTag != 'A')) {
« no previous file with comments | « chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698