Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Side by Side Diff: chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html

Issue 2131823004: Dialog message saying PIN is incorrect positioned correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Addressed comment. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!-- TODO(crbug.com/603217): Use i18n instead of string literals. Figure out 1 <!-- TODO(crbug.com/603217): Use i18n instead of string literals. Figure out
2 what i18n to use for keypad, ie, does 1 ABC make 2 what i18n to use for keypad, ie, does 1 ABC make
3 sense in every scenario? --> 3 sense in every scenario? -->
4 4
5 <link rel="import" href="chrome://resources/html/i18n_behavior.html"> 5 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/paper-styl es.html"> 8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/paper-styl es.html">
9 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.h tml"> 9 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.h tml">
10 10
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 } 95 }
96 96
97 .first-row { 97 .first-row {
98 height: 64px; 98 height: 64px;
99 min-height: 64px; 99 min-height: 64px;
100 padding: 28px 15px 12px 15px; 100 padding: 28px 15px 12px 15px;
101 } 101 }
102 102
103 #pin-input { 103 #pin-input {
104 -webkit-text-security: disc; 104 -webkit-text-security: disc;
105 background-color: white;
105 border: 0; 106 border: 0;
106 font-size: 18px; 107 font-size: 18px;
107 height: 64px; 108 height: 64px;
108 left: 20px; 109 left: 20px;
109 padding: 28px 3px 12px 3px; 110 padding: 28px 3px 12px 3px;
110 position: relative; 111 position: relative;
111 text-align: center;
112 width: 180px; 112 width: 180px;
113 } 113 }
114 114
115 #pin-input[type=number]::-webkit-inner-spin-button, 115 #pin-input[type=number]::-webkit-inner-spin-button,
116 #pin-input[type=number]::-webkit-outer-spin-button { 116 #pin-input[type=number]::-webkit-outer-spin-button {
117 -webkit-appearance: none; 117 -webkit-appearance: none;
118 margin: 0; 118 margin: 0;
119 } 119 }
120 120
121 /* Ensure that all children of paper-button do not consume events. This 121 /* Ensure that all children of paper-button do not consume events. This
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 </paper-button> 163 </paper-button>
164 <paper-button class="digit-button" on-tap="onNumberTap_" value="6"> 164 <paper-button class="digit-button" on-tap="onNumberTap_" value="6">
165 <inner-text>$i18n{pinKeyboard6}</inner-text> 165 <inner-text>$i18n{pinKeyboard6}</inner-text>
166 </paper-button> 166 </paper-button>
167 </div> 167 </div>
168 <div class="row keyboard"> 168 <div class="row keyboard">
169 <paper-button class="digit-button" on-tap="onNumberTap_" value="7"> 169 <paper-button class="digit-button" on-tap="onNumberTap_" value="7">
170 <inner-text>$i18n{pinKeyboard7}</inner-text> 170 <inner-text>$i18n{pinKeyboard7}</inner-text>
171 </paper-button> 171 </paper-button>
172 <paper-button class="digit-button center-button" on-tap="onNumberTap_" 172 <paper-button class="digit-button center-button" on-tap="onNumberTap_"
173 value="8">
173 <inner-text>$i18n{pinKeyboard8}</inner-text> 174 <inner-text>$i18n{pinKeyboard8}</inner-text>
174 </paper-button> 175 </paper-button>
175 <paper-button class="digit-button" on-tap="onNumberTap_" value="9"> 176 <paper-button class="digit-button" on-tap="onNumberTap_" value="9">
176 <inner-text>$i18n{pinKeyboard9}</inner-text> 177 <inner-text>$i18n{pinKeyboard9}</inner-text>
177 </paper-button> 178 </paper-button>
178 </div> 179 </div>
179 <div class="row keyboard"> 180 <div class="row keyboard">
180 <div class="digit-button"></div> 181 <div class="digit-button"></div>
181 <paper-button class="digit-button center-button" on-tap="onNumberTap_" 182 <paper-button class="digit-button center-button" on-tap="onNumberTap_"
182 value="0"> 183 value="0">
183 <inner-text>$i18n{pinKeyboard0}</inner-text> 184 <inner-text>$i18n{pinKeyboard0}</inner-text>
184 </paper-button> 185 </paper-button>
185 <paper-button class="digit-button clear-button" on-tap="onPinClear_"> 186 <paper-button class="digit-button clear-button" on-tap="onPinClear_">
186 <div class="icon-container"> 187 <div class="icon-container">
187 <iron-icon class="icon" icon="icons:clear"><iron-icon> 188 <iron-icon class="icon" icon="icons:clear"><iron-icon>
188 </div> 189 </div>
189 <inner-text class="icon-subheading"> 190 <inner-text class="icon-subheading">
190 $i18n{pinKeyboardClear} 191 $i18n{pinKeyboardClear}
191 </inner-text> 192 </inner-text>
192 </paper-button> 193 </paper-button>
193 </div> 194 </div>
194 </div> 195 </div>
195 </div> 196 </div>
196 </template> 197 </template>
197 <script src="pin_keyboard.js"></script> 198 <script src="pin_keyboard.js"></script>
198 </dom-module> 199 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698