Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2131823003: mash: Minor ash/common fixes for tray_display. (Closed)

Created:
4 years, 5 months ago by msw
Modified:
4 years, 5 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Minor ash/common fixes for tray_display. Just fixes some low hanging fruit here. (other big deps on DisplayManager; ScreenOrientationController) BUG=619636 TEST=compiles; unit tests; no behavior changes. R=jamescook@chromium.org Committed: https://crrev.com/6528d2fcc2c9ef8a4bd8ac33c05ba88e298abcc4 Cr-Commit-Position: refs/heads/master@{#404516}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M ash/system/chromeos/tray_display.h View 1 chunk +4 lines, -8 lines 0 comments Download
M ash/system/chromeos/tray_display.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ash/system/chromeos/tray_display_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
msw
Hey James, please take a look; thanks!
4 years, 5 months ago (2016-07-08 19:57:06 UTC) #1
James Cook
LGTM
4 years, 5 months ago (2016-07-08 20:39:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131823003/1
4 years, 5 months ago (2016-07-08 22:36:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 22:40:27 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 22:40:38 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 22:41:41 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6528d2fcc2c9ef8a4bd8ac33c05ba88e298abcc4
Cr-Commit-Position: refs/heads/master@{#404516}

Powered by Google App Engine
This is Rietveld 408576698