Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 2131813002: Revert of QUIC - Race Cert Verification with host resolution if certs are (Closed)

Created:
4 years, 5 months ago by hush (inactive)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, arv+watch_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of QUIC - Race Cert Verification with host resolution if certs are (patchset #4 id:100001 of https://codereview.chromium.org/2120703003/ ) Reason for revert: Failed cronet unit test and net unit test https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Data%20Reduction%20Proxy%20Builder/builds/2590/steps/cronet_unittests/logs/stdio https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Data%20Reduction%20Proxy%20Builder/builds/2590/steps/net_unittests/logs/stdio Original issue's description: > QUIC - Race Cert Verification with host resolution if certs are > availiable when race_cert_verification network session param is enabled. > > This experiment is not enabled in chromium. > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation > > R=eroman@chromium.org, mef@chromium.org, rch@chromium.org, > TBR=eroman@chromium.org (for net-internals changes) > > Committed: https://crrev.com/61f8d17a6a2ee893f42f62164a81026c56186c1d > Cr-Commit-Position: refs/heads/master@{#404296} TBR=eroman@chromium.org,mef@chromium.org,rch@chromium.org,rtenneti@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/379ab0ffcbdfe9012f972a44ca42cb84b9789fa1 Cr-Commit-Position: refs/heads/master@{#404311}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -492 lines) Patch
M chrome/browser/resources/net_internals/quic_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java View 1 chunk +1 line, -2 lines 0 comments Download
M components/cronet/url_request_context_config.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M components/cronet/url_request_context_config_unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/http/http_network_session.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M net/quic/crypto/proof_verifier.h View 1 chunk +0 lines, -20 lines 0 comments Download
M net/quic/crypto/proof_verifier_chromium.h View 1 chunk +0 lines, -7 lines 0 comments Download
M net/quic/crypto/proof_verifier_chromium.cc View 8 chunks +23 lines, -124 lines 0 comments Download
M net/quic/crypto/proof_verifier_chromium_test.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M net/quic/quic_stream_factory.h View 7 chunks +0 lines, -18 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 21 chunks +32 lines, -139 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 5 chunks +4 lines, -65 lines 0 comments Download
M net/quic/test_tools/quic_stream_factory_peer.h View 3 chunks +0 lines, -14 lines 0 comments Download
M net/quic/test_tools/quic_stream_factory_peer.cc View 4 chunks +2 lines, -35 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M net/url_request/url_request_context_builder.h View 2 chunks +0 lines, -6 lines 0 comments Download
M net/url_request/url_request_context_builder.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
hush (inactive)
Created Revert of QUIC - Race Cert Verification with host resolution if certs are
4 years, 5 months ago (2016-07-08 02:22:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131813002/1
4 years, 5 months ago (2016-07-08 02:22:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 02:23:53 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 02:26:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/379ab0ffcbdfe9012f972a44ca42cb84b9789fa1
Cr-Commit-Position: refs/heads/master@{#404311}

Powered by Google App Engine
This is Rietveld 408576698