Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 21318002: Use x86_64_*_operand in LEA splitters (Closed)

Created:
7 years, 4 months ago by Roland McGrath
Modified:
7 years, 4 months ago
Reviewers:
khim, sehr
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/nacl-gcc.git@master
Visibility:
Public.

Description

Use x86_64_*_operand in LEA splitters Similar to the previous fix, these patterns need to use a constraint that will reject a SYMBOL_REF expression in -m64 -fPIC. That is not how these patterns were handled in upstream -mx32 support. But the situation is substantially different there and possibly this is not the relevant change there because Pmode is SImode for -mx32 while it's still DImode for x86_64-nacl-gcc -m64. (That said, I don't actually understand what RTL transformations happen differently in this case upstream under -mx32 to prevent it from exhibiting this bug--which it does not--without this constraint change.) BUG= https://code.google.com/p/nativeclient/issues/detail?id=3598 TEST= toolchain trybots R=khim@chromium.org Committed: https://git.chromium.org/gitweb?p=native_client/nacl-gcc.git;a=commit;h=aca852e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M gcc/config/i386/i386.md View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Roland McGrath
7 years, 4 months ago (2013-07-31 02:38:51 UTC) #1
khim
LGTM The fact that upstream does not need this looks strange, though.
7 years, 4 months ago (2013-07-31 09:38:07 UTC) #2
Roland McGrath
7 years, 4 months ago (2013-07-31 16:35:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as raca852e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698