Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Unified Diff: mojo/common/common_custom_types.typemap

Issue 2131773003: Update mojo typemaps for base::Time* to pass by value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/common/common_custom_types.typemap
diff --git a/mojo/common/common_custom_types.typemap b/mojo/common/common_custom_types.typemap
index 8d88109d8c1352af4e1ba676325c3070c3417a7d..ce623878b58b1bd7875b33d94f06f5e77eb560e6 100644
--- a/mojo/common/common_custom_types.typemap
+++ b/mojo/common/common_custom_types.typemap
@@ -17,7 +17,7 @@ type_mappings = [
"mojo.common.mojom.FilePath=base::FilePath",
"mojo.common.mojom.DictionaryValue=base::DictionaryValue",
"mojo.common.mojom.ListValue=base::ListValue",
- "mojo.common.mojom.Time=base::Time",
- "mojo.common.mojom.TimeDelta=base::TimeDelta",
- "mojo.common.mojom.TimeTicks=base::TimeTicks",
+ "mojo.common.mojom.Time=base::Time[pass_by_value]",
yzshen1 2016/07/08 15:42:01 I am planning to replace "pass_by_value" with "mov
dcheng 2016/07/08 16:21:45 It seems unfortunate that we'll actively encourage
+ "mojo.common.mojom.TimeDelta=base::TimeDelta[pass_by_value]",
+ "mojo.common.mojom.TimeTicks=base::TimeTicks[pass_by_value]",
]

Powered by Google App Engine
This is Rietveld 408576698