[Oilpan]: Move StyleMedia to the oilpan heap using transition types.

[Oilpan]: Move StyleMedia to the oilpan heap using transition types.

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=341815
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170185

[Mads Ager (chromium), 2014-03-26 16:24:47]

LGTM, small and sweet! :-)

[wibling-chromium, 2014-03-26 16:29:49]

On 2014/03/26 16:24:47, Mads Ager (chromium) wrote:
> LGTM, small and sweet! :-)

Yes, doesn't get much smaller (or sweeter) :)

[haraken, 2014-03-27 00:50:07]

LGTM with a comment.

https://codereview.chromium.org/213173002/diff/1/Source/core/css/StyleMedia.h
File Source/core/css/StyleMedia.h (right):

https://codereview.chromium.org/213173002/diff/1/Source/core/css/StyleMedia.h...
Source/core/css/StyleMedia.h:39: class StyleMedia : public
RefCountedWillBeGarbageCollected<StyleMedia>, public DOMWindowProperty {

This needs to be RefCountedWillBeGarbageCollectedFinalized since
DOMWindowProperty needs a destructor.

[wibling-chromium, 2014-03-27 08:42:19]

Thanks for the review!

https://codereview.chromium.org/213173002/diff/1/Source/core/css/StyleMedia.h
File Source/core/css/StyleMedia.h (right):

https://codereview.chromium.org/213173002/diff/1/Source/core/css/StyleMedia.h...
Source/core/css/StyleMedia.h:39: class StyleMedia : public
RefCountedWillBeGarbageCollected<StyleMedia>, public DOMWindowProperty {
Thanks for catching that! Done.

[wibling-chromium, 2014-03-27 09:43:32]

The CQ bit was checked by wibling@chromium.org

[commit-bot: I haz the power, 2014-03-27 09:43:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wibling@chromium.org/213173002/20001

[commit-bot: I haz the power, 2014-03-27 10:52:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 10:52:22]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[wibling-chromium, 2014-03-27 10:57:57]

The CQ bit was checked by wibling@chromium.org

[commit-bot: I haz the power, 2014-03-27 10:58:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wibling@chromium.org/213173002/20001

[commit-bot: I haz the power, 2014-03-27 12:08:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 12:08:08]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[wibling-chromium, 2014-03-27 13:58:40]

The CQ bit was checked by wibling@chromium.org

[commit-bot: I haz the power, 2014-03-27 13:58:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wibling@chromium.org/213173002/20001

[commit-bot: I haz the power, 2014-03-27 15:03:27]

Change committed as 170185