components/startup_metric_utils/browser/startup_metric_utils.h - Issue 2131663002: Require a PrefService in startup_metric_utils::RecordBrowserMainMessageLoopStart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/startup_metric_utils/browser/startup_metric_utils.h

Issue 2131663002: Require a PrefService in startup_metric_utils::RecordBrowserMainMessageLoopStart (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/startup_metric_utils/browser/startup_metric_utils.cc » ('j') | components/startup_metric_utils/browser/startup_metric_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/startup_metric_utils/browser/startup_metric_utils.h

diff --git a/components/startup_metric_utils/browser/startup_metric_utils.h b/components/startup_metric_utils/browser/startup_metric_utils.h

index cdfb55c99ce50954e40baff65a3183f6f4123a6d..3d373c2a9de060db7767c2341754e0874a54b67d 100644

--- a/components/startup_metric_utils/browser/startup_metric_utils.h

+++ b/components/startup_metric_utils/browser/startup_metric_utils.h

@@ -78,9 +78,7 @@ void RecordExeMainEntryPointTime(const base::Time& time);

// Call this with the time recorded just before the message loop is started.

// |is_first_run| - is the current launch part of a first run. |pref_service| is

-// an optional parameter which, if provided, will be used to store state for

-// stats that span multiple startups; in its absence those stats will not be

-// recorded.

+// used to store state for stats that span multiple startups.

void RecordBrowserMainMessageLoopStart(const base::TimeTicks& ticks,

bool is_first_run,

PrefService* pref_service);