Require a PrefService in startup_metric_utils::RecordBrowserMainMessageLoopStart

Require a PrefService in startup_metric_utils::RecordBrowserMainMessageLoopStart

The PrefService argument was optional because it wasn't available in
components/html_viewer. Now that components/html_viewer is gone, a
PrefService should always be provided when calling
startup_metric_utils::RecordBrowserMainMessageLoopStart.

BUG=580211
Committed: https://crrev.com/3d6e82534e5e0a9dc85c909027dc380248fa5aab
Cr-Commit-Position: refs/heads/master@{#404451}

[fdoray, 2016-07-07 18:45:13]

fdoray@chromium.org changed reviewers:
+ gab@chromium.org

[fdoray, 2016-07-07 18:45:14]

PTAL

[gab, 2016-07-07 19:05:32]

lgtm w/ comment

https://codereview.chromium.org/2131663002/diff/1/components/startup_metric_u...
File components/startup_metric_utils/browser/startup_metric_utils.cc (right):

https://codereview.chromium.org/2131663002/diff/1/components/startup_metric_u...
components/startup_metric_utils/browser/startup_metric_utils.cc:205:
same_version_startup_count_suffix.push_back('.');
It starts with a '.' on 203 this adds a second one.

Please verify the resulting histogram in chrome://histograms before landing.

[fdoray, 2016-07-08 14:20:21]

https://codereview.chromium.org/2131663002/diff/1/components/startup_metric_u...
File components/startup_metric_utils/browser/startup_metric_utils.cc (right):

https://codereview.chromium.org/2131663002/diff/1/components/startup_metric_u...
components/startup_metric_utils/browser/startup_metric_utils.cc:205:
same_version_startup_count_suffix.push_back('.');
On 2016/07/07 19:05:31, gab wrote:
> It starts with a '.' on 203 this adds a second one.
> 
> Please verify the resulting histogram in chrome://histograms before landing.

Done.

[fdoray, 2016-07-08 14:20:26]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-07-08 14:20:26]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org
Link to the patchset: https://codereview.chromium.org/2131663002/#ps20001
(title: "fix suffix")

[commit-bot: I haz the power, 2016-07-08 14:21:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 18:46:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-08 18:49:01]

Description was changed from

==========
Require a PrefService in startup_metric_utils::RecordBrowserMainMessageLoopStart

The PrefService argument was optional because it wasn't available in
components/html_viewer. Now that components/html_viewer is gone, a
PrefService should always be provided when calling
startup_metric_utils::RecordBrowserMainMessageLoopStart.

BUG=580211
==========

to

==========
Require a PrefService in startup_metric_utils::RecordBrowserMainMessageLoopStart

The PrefService argument was optional because it wasn't available in
components/html_viewer. Now that components/html_viewer is gone, a
PrefService should always be provided when calling
startup_metric_utils::RecordBrowserMainMessageLoopStart.

BUG=580211

Committed: https://crrev.com/3d6e82534e5e0a9dc85c909027dc380248fa5aab
Cr-Commit-Position: refs/heads/master@{#404451}
==========

[commit-bot: I haz the power, 2016-07-08 18:49:02]

Patchset 2 (id:??) landed as
https://crrev.com/3d6e82534e5e0a9dc85c909027dc380248fa5aab
Cr-Commit-Position: refs/heads/master@{#404451}