Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: xfa/fxfa/parser/cxfa_simple_parser.h

Issue 2131653002: Cleanup ownership of parser members (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@parser_split
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/fxfa/parser/cxfa_document_parser.cpp ('k') | xfa/fxfa/parser/cxfa_simple_parser.cpp » ('j') | xfa/fxfa/parser/cxfa_simple_parser.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fxfa/parser/cxfa_simple_parser.h
diff --git a/xfa/fxfa/parser/cxfa_simple_parser.h b/xfa/fxfa/parser/cxfa_simple_parser.h
index d49008da9111742e95eedcc0c774f1e13242abba..e8b39b09bcd2150520788c371552618fb4ec3fcc 100644
--- a/xfa/fxfa/parser/cxfa_simple_parser.h
+++ b/xfa/fxfa/parser/cxfa_simple_parser.h
@@ -7,6 +7,8 @@
#ifndef XFA_FXFA_PARSER_CXFA_SIMPLE_PARSER_H_
#define XFA_FXFA_PARSER_CXFA_SIMPLE_PARSER_H_
+#include <memory>
+
#include "xfa/fde/xml/fde_xml_imp.h"
#include "xfa/fxfa/include/fxfa_basic.h"
@@ -73,8 +75,8 @@ class CXFA_SimpleParser {
void SetFactory(CXFA_Document* pFactory);
CXFA_XMLParser* m_pXMLParser;
- CFDE_XMLDoc* m_pXMLDoc;
- IFX_Stream* m_pStream;
+ std::unique_ptr<CFDE_XMLDoc> m_pXMLDoc;
+ std::unique_ptr<IFX_Stream, ReleaseDeleter<IFX_Stream>> m_pStream;
IFX_FileRead* m_pFileRead;
CXFA_Document* m_pFactory;
CXFA_Node* m_pRootNode;
« no previous file with comments | « xfa/fxfa/parser/cxfa_document_parser.cpp ('k') | xfa/fxfa/parser/cxfa_simple_parser.cpp » ('j') | xfa/fxfa/parser/cxfa_simple_parser.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698