Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2131643003: Clean up SimulatorHelper code. (Closed)

Created:
4 years, 5 months ago by alph
Modified:
4 years, 5 months ago
Reviewers:
lpy, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Clean up SimulatorHelper code. Committed: https://crrev.com/8ee236e144c95f719eebe0bf08c85d290f801abe Cr-Commit-Position: refs/heads/master@{#37619}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -28 lines) Patch
M src/profiler/tick-sample.cc View 2 chunks +22 lines, -28 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
alph
4 years, 5 months ago (2016-07-07 20:43:26 UTC) #2
lpy
lgtm
4 years, 5 months ago (2016-07-07 20:57:34 UTC) #3
Yang
On 2016/07/07 20:57:34, lpy wrote: > lgtm lgtm
4 years, 5 months ago (2016-07-08 08:34:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131643003/1
4 years, 5 months ago (2016-07-09 00:49:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-09 02:05:05 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8ee236e144c95f719eebe0bf08c85d290f801abe Cr-Commit-Position: refs/heads/master@{#37619}
4 years, 5 months ago (2016-07-09 02:06:58 UTC) #9
Michael Achenbach
4 years, 5 months ago (2016-07-11 07:39:56 UTC) #10
Message was sent while issue was closed.
Note: Collective revert: https://codereview.chromium.org/2138643003/

Powered by Google App Engine
This is Rietveld 408576698