[ash-md] Makes Ctrl+W accelerator close a selected window in overview mode

ash/common/wm/overview/window_selector.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/wm/overview/window_selector.h"
 
 #include <algorithm>
 #include <functional>
 #include <set>
 #include <utility>
@@ skipping 477 matching lines @@
     case ui::VKEY_UP:
       num_key_presses_++;
       Move(WindowSelector::UP, true);
       break;
     case ui::VKEY_DOWN:
       num_key_presses_++;
       Move(WindowSelector::DOWN, true);
       break;
     case ui::VKEY_RIGHT:
     case ui::VKEY_TAB:
-      num_key_presses_++;
-      Move(WindowSelector::RIGHT, true);
-      break;
+      if (!(key_event.flags() & ui::EF_SHIFT_DOWN) ||
+          (key_event.key_code() != ui::VKEY_TAB)) {
+        num_key_presses_++;
+        Move(WindowSelector::RIGHT, true);
+        break;
+      }
     case ui::VKEY_LEFT:
       num_key_presses_++;
       Move(WindowSelector::LEFT, true);
       break;
+    case ui::VKEY_W:
+      if (!(key_event.flags() & ui::EF_CONTROL_DOWN) ||
+          !grid_list_[selected_grid_index_]->is_selecting()) {
+        // allow the textfield to handle 'W' key when not used with Ctrl.

[tdanderson, 2016/07/07 21:26:49]

nit: 'Allow' instead of 'allow'

[varkha, 2016/07/08 00:00:12]

Done.

+        return false;
+      }
+      grid_list_[selected_grid_index_]->SelectedWindow()->CloseWindow();

[tdanderson, 2016/07/07 21:26:49]

Either here or in a follow-up CL, consider adding two user action counts: one
which fires when a window is closed by keyboard, and one which fires when a
window is closed by clicking/tapping the close button in the header. This is
cheap to do and maintains the already-excellent UMA coverage we have on overview
mode.

[varkha, 2016/07/08 00:00:12]

Done.

+      break;
     case ui::VKEY_RETURN:
       // Ignore if no item is selected.
       if (!grid_list_[selected_grid_index_]->is_selecting())
         return false;
       UMA_HISTOGRAM_COUNTS_100("Ash.WindowSelector.ArrowKeyPresses",
                                num_key_presses_);
       UMA_HISTOGRAM_CUSTOM_COUNTS("Ash.WindowSelector.KeyPressesOverItemsRatio",
                                   (num_key_presses_ * 100) / num_items_, 1, 300,
                                   30);
       WmShell::Get()->RecordUserMetricsAction(UMA_WINDOW_OVERVIEW_ENTER_KEY);
@@ skipping 172 matching lines @@
   for (size_t i = 0; i <= grid_list_.size() &&
                      grid_list_[selected_grid_index_]->Move(direction, animate);
        i++) {
     selected_grid_index_ =
         (selected_grid_index_ + display_direction + grid_list_.size()) %
         grid_list_.size();
   }
 }
 
 }  // namespace ash