Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2719)

Unified Diff: appengine/chromium_rietveld/codereview/views.py

Issue 2131593002: Rietveld: Mark CQ Dry Run messages as autogenerated. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/chromium_rietveld/codereview/views.py
diff --git a/appengine/chromium_rietveld/codereview/views.py b/appengine/chromium_rietveld/codereview/views.py
index 3ab4020663bf31badec974d2a2e39b6e9379426c..ddb4c440dd68ce34b0b18e0316282639352b8304 100644
--- a/appengine/chromium_rietveld/codereview/views.py
+++ b/appengine/chromium_rietveld/codereview/views.py
@@ -3419,11 +3419,15 @@ def publish(request):
if comments:
logging.warn('Publishing %d comments', len(comments))
# Email only the triggerer and the CL owner if it was a CQ dry run request.
- # More details are in crbug.com/476883
+ # More details are in http://crbug.com/476883.
email_to = None
+ # Mark CQ dry run messages as autogenerated.
+ # More details: http://crbug.com/596249.
+ auto_generated = False
if (request.user.email().lower() in (CQ_COMMIT_BOT_EMAIL, CQ_SERVICE_ACCOUNT)
and 'dry run' in form.cleaned_data['message'].lower()):
email_to = [issue.owner.email()]
+ auto_generated = True
if (issue.cq_dry_run_last_triggered_by and
issue.cq_dry_run_last_triggered_by != issue.owner.email()):
email_to.append(issue.cq_dry_run_last_triggered_by)
@@ -3433,7 +3437,8 @@ def publish(request):
form.cleaned_data['send_mail'],
draft=draft_message,
email_to=email_to,
- in_reply_to=form.cleaned_data.get('in_reply_to'))
+ in_reply_to=form.cleaned_data.get('in_reply_to'),
+ auto_generated=auto_generated)
tbd.append(msg)
for obj in tbd:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698