runtime/vm/flow_graph_compiler_mips.cc - Issue 2131583002: Optimized megamorphic stubs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_mips.cc

Issue 2131583002: Optimized megamorphic stubs (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Addressed Florians comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_compiler_mips.cc

diff --git a/runtime/vm/flow_graph_compiler_mips.cc b/runtime/vm/flow_graph_compiler_mips.cc

index 2376554768577c5596bbfc2ea06cd07f8844485a..97d2f3a23f624fc74d02b4f14a0c4edd77cf505d 100644

--- a/runtime/vm/flow_graph_compiler_mips.cc

+++ b/runtime/vm/flow_graph_compiler_mips.cc

@@ -1350,7 +1350,8 @@ void FlowGraphCompiler::EmitMegamorphicInstanceCall(

}

__ LoadObject(S5, cache);

if (FLAG_use_megamorphic_stub) {

- __ BranchLink(*StubCode::MegamorphicLookup_entry());

+ __ lw(T9, Address(THR, Thread::megamorphic_lookup_entry_point_offset()));

+ __ jalr(T9);

} else {

StubCode::EmitMegamorphicLookup(assembler());

}