Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2131563002: Stop using GetAudioHardwareConfig to get audio parameters in WebRtcLocalAudioSourceProvider. (Closed)

Created:
4 years, 5 months ago by Guido Urdaneta
Modified:
4 years, 5 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, o1ka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop using GetAudioHardwareConfig to get audio parameters in WebRtcLocalAudioSourceProvider. BUG=611404 Committed: https://crrev.com/5b599cad423a58e34a49be04da7f197313e055e6 Cr-Commit-Position: refs/heads/master@{#404188}

Patch Set 1 #

Patch Set 2 : check frame #

Patch Set 3 : minor formatting change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M content/renderer/media/webrtc_local_audio_source_provider.cc View 1 2 2 chunks +14 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Guido Urdaneta
Hi, PTAL
4 years, 5 months ago (2016-07-07 15:45:13 UTC) #2
tommi (sloooow) - chröme
lgtm
4 years, 5 months ago (2016-07-07 15:47:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131563002/40001
4 years, 5 months ago (2016-07-07 16:00:26 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-07 18:36:05 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 18:39:54 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/5b599cad423a58e34a49be04da7f197313e055e6
Cr-Commit-Position: refs/heads/master@{#404188}

Powered by Google App Engine
This is Rietveld 408576698