Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 2131483003: Allow 'alphabetic' for alignment-baseline and dominant-baseline (Closed)

Created:
4 years, 5 months ago by fs
Modified:
4 years, 5 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow 'alphabetic' for alignment-baseline and dominant-baseline This keyword is not included in any of the ranges used, so needs to be mentioned specifically. BUG=620618 Committed: https://crrev.com/a5d20779f51c6f84061df5610320260faef0db52 Cr-Commit-Position: refs/heads/master@{#404338}

Patch Set 1 #

Patch Set 2 : TEs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/css/css-keyword-properties.html View 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
fs
4 years, 5 months ago (2016-07-07 15:49:38 UTC) #2
Timothy Loh
gtm
4 years, 5 months ago (2016-07-08 01:35:59 UTC) #3
Timothy Loh
On 2016/07/08 01:35:59, Timothy Loh wrote: > gtm lgtm :)
4 years, 5 months ago (2016-07-08 01:36:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131483003/20001
4 years, 5 months ago (2016-07-08 08:08:33 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-08 09:46:08 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 09:46:43 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 09:49:22 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a5d20779f51c6f84061df5610320260faef0db52
Cr-Commit-Position: refs/heads/master@{#404338}

Powered by Google App Engine
This is Rietveld 408576698