Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 2131483002: Avoid Context::Enter and Context::Exit if we're reentering the active and last entered context (Closed)

Created:
4 years, 5 months ago by Toon Verwaest
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Avoid Context::Enter and Context::Exit if we're reentering the active and last entered context A bit of browsing around indicates that the new fast-path is taken most of the time: 3496 Entering new 152295 Reentering same BUG= Committed: https://crrev.com/1829eb661ef1cf432fb551bcb193f521a219d490 Cr-Commit-Position: refs/heads/master@{#37570}

Patch Set 1 #

Patch Set 2 : also deal with isolate->context() still being null #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M src/api.cc View 1 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Toon Verwaest
ptal
4 years, 5 months ago (2016-07-07 06:16:40 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-07 06:25:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131483002/20001
4 years, 5 months ago (2016-07-07 07:13:36 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-07 07:35:41 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/1829eb661ef1cf432fb551bcb193f521a219d490 Cr-Commit-Position: refs/heads/master@{#37570}
4 years, 5 months ago (2016-07-07 07:38:05 UTC) #10
haraken
Great, LGTM!
4 years, 5 months ago (2016-07-07 08:41:58 UTC) #11
Jakob Kummerow
4 years, 5 months ago (2016-07-11 10:01:49 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2140563002/ by jkummerow@chromium.org.

The reason for reverting is: crashes: crbug.com/626719.

Powered by Google App Engine
This is Rietveld 408576698