Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2233)

Unified Diff: appengine/findit/handlers/flake/check_flake.py

Issue 2131473003: UI for the regression range test. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: +tests and lint Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/handlers/flake/check_flake.py
diff --git a/appengine/findit/handlers/flake/check_flake.py b/appengine/findit/handlers/flake/check_flake.py
index 9cbfe9ee8818f968768e81d4e3a4ab41e434ea6d..aa76e4d65eefa736236b081f6c81fd9d84ff1b9b 100644
--- a/appengine/findit/handlers/flake/check_flake.py
+++ b/appengine/findit/handlers/flake/check_flake.py
@@ -2,33 +2,31 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+from common import constants
from common.base_handler import BaseHandler
from common.base_handler import Permission
+from waterfall.flake.initialize_flake_pipeline import ScheduleAnalysisIfNeeded
+
+from google.appengine.api import users
chanli 2016/07/27 21:52:18 This import should be at the top and in a separate
caiw 2016/07/27 23:27:11 Done.
class CheckFlake(BaseHandler):
PERMISSION_LEVEL = Permission.CORP_USER
def HandleGet(self):
-
# Get input parameters.
# pylint: disable=W0612
master_name = self.request.get('master_name').strip()
builder_name = self.request.get('builder_name').strip()
build_number = int(self.request.get('build_number').strip())
- test_target_name = self.request.get('test_target_name').strip()
- testcase = self.request.get('testcase').strip()
-
- # TODO(caiw): Get status of master_analysis from database.
-
- # TODO(caiw): If there is a completed master_analysis, return
- # the template which displays it.
-
- # TODO(caiw): If the current master_analysis has an error,
- # delete it.
-
- # TODO(caiw): If there is no master_analysis, create one.
-
- # TODO(caiw): Trigger pipeline.
-
- # TODO(caiw): Return the appropriate template based on the case.
+ step_name = self.request.get('test_target_name').strip()
+ test_name = self.request.get('test_name').strip()
+ force = (users.is_current_user_admin() and
+ self.request.get('force') == '1')
+
+ ScheduleAnalysisIfNeeded(master_name, builder_name, build_number, step_name,
+ test_name, force=force,
+ queue_name=constants.WATERFALL_ANALYSIS_QUEUE)
+ return {
+ 'template': 'flake/result.html'
+ }

Powered by Google App Engine
This is Rietveld 408576698