Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2131473003: UI for the regression range test. (Closed)

Created:
4 years, 5 months ago by caiw
Modified:
4 years, 4 months ago
Reviewers:
chanli, stgao, lijeffrey
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 8

Patch Set 2 : Removed logic from check_flake, made findit reference correct template for flake. #

Total comments: 2

Patch Set 3 : removed print #

Patch Set 4 : removed print #

Patch Set 5 : Added tests #

Patch Set 6 : Added tests #

Patch Set 7 : +tests and lint #

Total comments: 10

Patch Set 8 : addressed comments #

Patch Set 9 : dashboard and graphs for finding regression range #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -8 lines) Patch
M appengine/findit/handlers/flake/check_flake.py View 1 2 3 4 5 6 7 8 1 chunk +13 lines, -5 lines 0 comments Download
A appengine/findit/handlers/flake/flake_dashboard.py View 1 2 3 4 5 6 7 8 1 chunk +24 lines, -0 lines 0 comments Download
M appengine/findit/main.py View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -0 lines 0 comments Download
A appengine/findit/templates/flake/dashboard.html View 1 2 3 4 5 6 7 8 1 chunk +26 lines, -0 lines 0 comments Download
M appengine/findit/templates/flake/result.html View 1 2 3 4 5 6 7 8 1 chunk +53 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (4 generated)
caiw
I cut up the provisionally running pipeline into 3 CLs. This one contains the handler ...
4 years, 5 months ago (2016-07-07 20:50:32 UTC) #2
stgao
https://codereview.chromium.org/2131473003/diff/1/appengine/findit/handlers/flake/check_flake.py File appengine/findit/handlers/flake/check_flake.py (right): https://codereview.chromium.org/2131473003/diff/1/appengine/findit/handlers/flake/check_flake.py#newcode30 appengine/findit/handlers/flake/check_flake.py:30: analysis = MasterFlakeAnalysis.Get(master_name, builder_name, step_name) Should we use the ...
4 years, 5 months ago (2016-07-09 00:12:24 UTC) #4
caiw
https://codereview.chromium.org/2131473003/diff/1/appengine/findit/handlers/flake/check_flake.py File appengine/findit/handlers/flake/check_flake.py (right): https://codereview.chromium.org/2131473003/diff/1/appengine/findit/handlers/flake/check_flake.py#newcode30 appengine/findit/handlers/flake/check_flake.py:30: analysis = MasterFlakeAnalysis.Get(master_name, builder_name, step_name) On 2016/07/09 00:12:24, stgao ...
4 years, 5 months ago (2016-07-14 00:59:34 UTC) #5
stgao
As we discussed, this CL also needs some cleanup. https://codereview.chromium.org/2131473003/diff/1/appengine/findit/templates/flake/error.html File appengine/findit/templates/flake/error.html (right): https://codereview.chromium.org/2131473003/diff/1/appengine/findit/templates/flake/error.html#newcode1 appengine/findit/templates/flake/error.html:1: ...
4 years, 5 months ago (2016-07-14 21:17:58 UTC) #6
chanli
https://codereview.chromium.org/2131473003/diff/20001/appengine/findit/handlers/flake/check_flake.py File appengine/findit/handlers/flake/check_flake.py (right): https://codereview.chromium.org/2131473003/diff/20001/appengine/findit/handlers/flake/check_flake.py#newcode22 appengine/findit/handlers/flake/check_flake.py:22: print self.request Please remove these print statements when you're ...
4 years, 5 months ago (2016-07-19 20:56:12 UTC) #7
caiw
Removed the print statements. https://codereview.chromium.org/2131473003/diff/20001/appengine/findit/handlers/flake/check_flake.py File appengine/findit/handlers/flake/check_flake.py (right): https://codereview.chromium.org/2131473003/diff/20001/appengine/findit/handlers/flake/check_flake.py#newcode22 appengine/findit/handlers/flake/check_flake.py:22: print self.request On 2016/07/19 20:56:12, ...
4 years, 5 months ago (2016-07-21 18:22:50 UTC) #8
chanli
On 2016/07/21 18:22:50, caiw wrote: > Removed the print statements. > > https://codereview.chromium.org/2131473003/diff/20001/appengine/findit/handlers/flake/check_flake.py > File ...
4 years, 5 months ago (2016-07-21 21:11:33 UTC) #9
caiw
+ tests and lint
4 years, 5 months ago (2016-07-25 21:50:08 UTC) #10
chanli
https://codereview.chromium.org/2131473003/diff/120001/appengine/findit/handlers/flake/check_flake.py File appengine/findit/handlers/flake/check_flake.py (right): https://codereview.chromium.org/2131473003/diff/120001/appengine/findit/handlers/flake/check_flake.py#newcode10 appengine/findit/handlers/flake/check_flake.py:10: from google.appengine.api import users This import should be at ...
4 years, 4 months ago (2016-07-27 21:52:18 UTC) #11
caiw
https://codereview.chromium.org/2131473003/diff/120001/appengine/findit/handlers/flake/check_flake.py File appengine/findit/handlers/flake/check_flake.py (right): https://codereview.chromium.org/2131473003/diff/120001/appengine/findit/handlers/flake/check_flake.py#newcode10 appengine/findit/handlers/flake/check_flake.py:10: from google.appengine.api import users On 2016/07/27 21:52:18, chanli wrote: ...
4 years, 4 months ago (2016-07-27 23:27:11 UTC) #12
chanli
On 2016/07/27 23:27:11, caiw wrote: > https://codereview.chromium.org/2131473003/diff/120001/appengine/findit/handlers/flake/check_flake.py > File appengine/findit/handlers/flake/check_flake.py (right): > > https://codereview.chromium.org/2131473003/diff/120001/appengine/findit/handlers/flake/check_flake.py#newcode10 > ...
4 years, 4 months ago (2016-07-28 18:32:42 UTC) #13
lijeffrey
lgtm
4 years, 4 months ago (2016-07-28 19:10:56 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131473003/140001
4 years, 4 months ago (2016-07-28 19:24:19 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 19:37:47 UTC) #18
Message was sent while issue was closed. 
Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/infra/infra/+/879d2e6c05a657ea3ffe6a39213b1...

Powered by Google App Engine
This is Rietveld 408576698