Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2131463005: In print-stale-test-expectations-entries, avoid repeating the same request. (Closed)

Created:
4 years, 5 months ago by qyearsley
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, nainar
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In print-stale-test-expectations-entries, avoid repeating the same request. When running print-stale-test-expectations-entries, I noticed that it makes a request for each line even if it already checked whether a particular bug is stale; this change would speed up print-stale-test-expectations-entries by saving the results of the request about the state of the bug. BUG=597797 Committed: https://crrev.com/420dc135ca4155874320b02ef6e1ba3314e168dd Cr-Commit-Position: refs/heads/master@{#404680}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M third_party/WebKit/Tools/Scripts/print-stale-test-expectations-entries View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
qyearsley
4 years, 5 months ago (2016-07-07 18:27:18 UTC) #3
nainar
lgtm
4 years, 5 months ago (2016-07-10 23:38:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131463005/1
4 years, 5 months ago (2016-07-11 15:55:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 17:05:26 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 17:05:34 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/420dc135ca4155874320b02ef6e1ba3314e168dd Cr-Commit-Position: refs/heads/master@{#404680}
4 years, 5 months ago (2016-07-11 17:06:44 UTC) #10
Dirk Pranke
4 years, 4 months ago (2016-08-09 03:41:01 UTC) #11
Message was sent while issue was closed.
lgtm (very belatedly).

Powered by Google App Engine
This is Rietveld 408576698