Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2131463003:
Fix stream_client() in bootstrap.py. (Closed)
|
Created:
4 years, 5 months ago by nicholaslin Modified:
4 years, 5 months ago CC:
chromium-reviews, infra-reviews+luci-py_chromium.org Base URL:
https://github.com/luci/luci-py@master Target Ref:
refs/heads/master Project:
luci-py Visibility:
Public. |
DescriptionFix stream_client() in bootstrap.py.
BUG=626380
Committed: https://github.com/luci/luci-py/commit/6b78e815ed02585b6701aba195c6506c929eeecf
Patch Set 1 #Patch Set 2 : Delete additional whitespace. #Messages
Total messages: 19 (9 generated)
The CQ bit was checked by nicholaslin@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== Fix stream_client() in bootstrap.py. BUG=626380 ========== to ========== Fix stream_client() in bootstrap.py. BUG=626380 ==========
nicholaslin@google.com changed reviewers: + dnj@chromium.org
Ptal. Changing stream_client() in bootstrap.py to call the top level create() method in stream.py.
dnj@google.com changed reviewers: + dnj@google.com
The CQ bit was checked by dnj@google.com
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by dnj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix stream_client() in bootstrap.py. BUG=626380 ========== to ========== Fix stream_client() in bootstrap.py. BUG=626380 Committed: https://github.com/luci/luci-py/commit/6b78e815ed02585b6701aba195c6506c929eeecf ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://github.com/luci/luci-py/commit/6b78e815ed02585b6701aba195c6506c929eeecf
Message was sent while issue was closed.
CQ bit was unchecked. |
