Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1142)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2131423003: [Downloads] Add a browser test for <a download> with cross origin iframe. (Closed)

Created:
4 years, 5 months ago by asanka
Modified:
4 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Downloads] Add a browser test for <a download> with cross origin iframe. R=brettw@chromium.org BUG=596283 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/9b526a95cf600ccd10b03b7881c957ba2487ae3e Cr-Commit-Position: refs/heads/master@{#405150}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, --1 lines) Patch
M content/browser/download/download_browsertest.cc View 2 chunks +43 lines, -0 lines 0 comments Download
A content/test/data/download/iframe-host.html View 1 chunk +11 lines, -0 lines 0 comments Download
A + content/test/data/download/iframe-host.html.mock-http-headers View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
asanka
4 years, 5 months ago (2016-07-09 00:23:59 UTC) #1
brettw
LGTM!
4 years, 5 months ago (2016-07-12 20:37:19 UTC) #2
asanka
On 2016/07/12 at 20:37:19, brettw wrote: > LGTM! Thanks!
4 years, 5 months ago (2016-07-12 21:51:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131423003/1
4 years, 5 months ago (2016-07-12 21:53:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/166615)
4 years, 5 months ago (2016-07-12 23:15:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131423003/1
4 years, 5 months ago (2016-07-12 23:24:44 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191886)
4 years, 5 months ago (2016-07-13 01:08:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131423003/1
4 years, 5 months ago (2016-07-13 14:09:48 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 14:48:55 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 14:52:11 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9b526a95cf600ccd10b03b7881c957ba2487ae3e
Cr-Commit-Position: refs/heads/master@{#405150}

Powered by Google App Engine
This is Rietveld 408576698