Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: base/BUILD.gn

Issue 2131423002: Implement use_cfi_cast to optionally enable cast checks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Localize CFI_CAST_CHECK define Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/base.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index e44570c706c612d1dbe7e9add24cd7d7272244c3..b06028be6a61a99db858616ea53b4f340074a531 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -1979,6 +1979,8 @@ test("base_unittests") {
"win/wrapped_window_proc_unittest.cc",
]
+ defines = []
+
deps = [
":base",
":i18n",
@@ -2009,7 +2011,7 @@ test("base_unittests") {
# Allow more direct string conversions on platforms with native utf8
# strings
if (is_mac || is_ios || is_chromeos || is_chromecast) {
- defines = [ "SYSTEM_NATIVE_UTF8" ]
+ defines += [ "SYSTEM_NATIVE_UTF8" ]
}
if (is_android) {
@@ -2114,6 +2116,11 @@ test("base_unittests") {
# data += [ "$root_out_dir/base_unittests.dSYM/" ]
}
}
+
+ if (use_cfi_cast) {
+ # TODO(krasin): remove CFI_CAST_CHECK, see https://crbug.com/626794.
+ defines += [ "CFI_CAST_CHECK" ]
+ }
}
action("build_date") {
« no previous file with comments | « no previous file | base/base.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698