Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2131413002: [Chromecast] Update media time when playback is started (Closed)

Created:
4 years, 5 months ago by servolk
Modified:
4 years, 5 months ago
Reviewers:
slan
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org, esum
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Update media time when playback is started When CMA media pipeline is started we post a task that will continuouly update media time. But since that task is posted, it won't run right away. In the meantime somebody might call GetMediaTime and will get an invalid value (kNoTimestamp). To avoid this we can just set the last_media_time_ right away for the first time when starting playback. This will ensure that we have valid media time even before the first UpdateMediaTime task invocation. BUG=internal b/30035825 Committed: https://crrev.com/37162ce39d854bbc98fab1c6a3c6c1291066d28a Cr-Commit-Position: refs/heads/master@{#404513}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chromecast/media/cma/pipeline/media_pipeline_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
servolk
4 years, 5 months ago (2016-07-08 21:28:16 UTC) #3
slan
lgtm
4 years, 5 months ago (2016-07-08 21:33:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131413002/1
4 years, 5 months ago (2016-07-08 22:11:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 22:33:53 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 22:34:07 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 22:36:46 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37162ce39d854bbc98fab1c6a3c6c1291066d28a
Cr-Commit-Position: refs/heads/master@{#404513}

Powered by Google App Engine
This is Rietveld 408576698