Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2131353002: Moving all for test keeps into for test flags file. (Closed)

Created:
4 years, 5 months ago by smaier
Modified:
4 years, 5 months ago
Reviewers:
Yaron, Peter Wen, agrieve
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@testapk
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moving all for test keeps into for test flags file. This saves 137kb of .dex size and 16kb of dirty memory per process. BUG=626710 Committed: https://crrev.com/385a49f0676c8cba918439054e21c9bf5a24b914 Cr-Commit-Position: refs/heads/master@{#406544}

Patch Set 1 #

Patch Set 2 : Moving all for test keeps into for test flags file #

Total comments: 2

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -87 lines) Patch
M chrome/android/java/proguard.flags View 1 2 2 chunks +0 lines, -87 lines 0 comments Download
M testing/android/proguard_for_test.flags View 1 2 1 chunk +87 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (10 generated)
smaier
4 years, 5 months ago (2016-07-08 17:42:45 UTC) #4
Yaron
lgtm but obviously depends on the other cl https://codereview.chromium.org/2131353002/diff/20001/chrome/android/java/proguard.flags File chrome/android/java/proguard.flags (left): https://codereview.chromium.org/2131353002/diff/20001/chrome/android/java/proguard.flags#oldcode225 chrome/android/java/proguard.flags:225: -keep ...
4 years, 5 months ago (2016-07-08 21:29:27 UTC) #5
smaier
https://codereview.chromium.org/2131353002/diff/20001/chrome/android/java/proguard.flags File chrome/android/java/proguard.flags (left): https://codereview.chromium.org/2131353002/diff/20001/chrome/android/java/proguard.flags#oldcode225 chrome/android/java/proguard.flags:225: -keep class org.chromium.sync.protocol.* { *; } On 2016/07/08 21:29:27, ...
4 years, 5 months ago (2016-07-11 14:54:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131353002/40001
4 years, 5 months ago (2016-07-20 13:18:36 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-20 13:23:01 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 13:24:32 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/385a49f0676c8cba918439054e21c9bf5a24b914
Cr-Commit-Position: refs/heads/master@{#406544}

Powered by Google App Engine
This is Rietveld 408576698