Issue 213133002: Don't try to use ASan on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 213133002: Don't try to use ASan on Windows (Closed)

Created:
6 years, 9 months ago by Jakob Kummerow

Modified:
6 years, 9 months ago

Reviewers:
sebmarchand (DO NOT USE), kcc1, Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Don't try to use ASan on Windows Let ASan support depend on __has_feature(address_sanitizer) instead of defined(ADDRESS_SANITIZER) R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20287

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -7 lines)			Patch
M	build/standalone.gypi	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/zone.h	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	src/zone-inl.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 5 (0 generated)

Jakob Kummerow

Committed patchset #1 manually as r20287 (presubmit successful).

6 years, 9 months ago (2014-03-26 16:19:13 UTC) #3

kcc1

lgtm LGTM, but maybe name it V8_USE_ADDRESS_SANITIZER_ANNOTATIONS

6 years, 9 months ago (2014-03-26 16:19:25 UTC) #4

sebmarchand (DO NOT USE)

6 years, 9 months ago (2014-03-27 12:01:08 UTC) #5

Message was sent while issue was closed.

Please not that once this CL land https://codereview.chromium.org/212763004/
you'll be able to revert this safely.