[Cronet] Check whether request is done before spinning up message loop

components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net.urlconnection;
 
 import android.util.Pair;
 
 import org.chromium.base.Log;
 import org.chromium.net.CronetEngine;
@@ skipping 451 matching lines @@
                 }
                 if (instanceFollowRedirects && sameProtocol) {
                     mRequest.followRedirect();
                     return;
                 }
             } catch (MalformedURLException e) {
                 // Ignored. Just cancel the request and not follow the redirect.
             }
             mResponseInfo = info;
             mRequest.cancel();
-            setResponseDataCompleted(null);
+            setRequestCompleted(null);
         }
 
         @Override
         public void onSucceeded(UrlRequest request, UrlResponseInfo info) {
             mResponseInfo = info;
-            setResponseDataCompleted(null);
+            setRequestCompleted(null);
         }
 
         @Override
         public void onFailed(
                 UrlRequest request, UrlResponseInfo info, UrlRequestException exception) {
             if (exception == null) {
                 throw new IllegalStateException(
                         "Exception cannot be null in onFailed.");
             }
             mResponseInfo = info;
             mException = exception;
-            setResponseDataCompleted(mException);
+            setRequestCompleted(mException);
         }
 
         @Override
         public void onCanceled(UrlRequest request, UrlResponseInfo info) {
             mResponseInfo = info;
-            setResponseDataCompleted(new IOException("stream closed"));
+            setRequestCompleted(new IOException("stream closed"));
         }
 
         /**
          * Notifies {@link #mInputStream} that transferring of response data has
          * completed.
          * @param exception if not {@code null}, it is the exception to report when
          *            caller tries to read more data.
          */
-        private void setResponseDataCompleted(IOException exception) {
+        private void setRequestCompleted(IOException exception) {

[mef, 2016/07/08 17:42:06]

Why the rename? Can you update the comment?

[xunjieli, 2016/07/08 17:56:26]

Done.  I think it is not neccessary to change it, so I've reverted to the old
naming. Thanks!

             if (mInputStream != null) {
                 mInputStream.setResponseDataCompleted(exception);
             }
+            if (mOutputStream != null) {
+                mOutputStream.setRequestCompleted(exception);
+            }
             mMessageLoop.quit();
         }
     }
 
     /**
      * Blocks until the respone headers are received.
      */
     private void getResponse() throws IOException {
         // Check to see if enough data has been received.
         if (mOutputStream != null) {
@@ skipping 78 matching lines @@
             // Strips Content-Encoding response header. See crbug.com/592700.
             if (!entry.getKey().equalsIgnoreCase("Content-Encoding")) {
                 mResponseHeadersList.add(
                         new AbstractMap.SimpleImmutableEntry<String, String>(entry));
             }
         }
         mResponseHeadersList = Collections.unmodifiableList(mResponseHeadersList);
         return mResponseHeadersList;
     }
 }