Make all tests profilable

Make all tests profilable

We did not run profiling on unit and perf tests even when the
enable_profiling build flag was present. In order to dump profiling data,
base::debug::StartProfiling(..) must be called somewhere. I've moved that
code to base::TestSuite. Note that this code is a no-op unless the profiling
build flag is present.

BUG=624459
TBR=sky@chromium.org

Committed: https://crrev.com/2573dfb1ec3c99ab6d7c1863b8e6a7a24f4fe626
Cr-Commit-Position: refs/heads/master@{#404522}

[Fady Samuel, 2016-07-08 16:07:18]

fsamuel@chromium.org changed reviewers:
+ danakj@chromium.org, sadrul@chromium.org

[Fady Samuel, 2016-07-08 16:07:18]

+sadrul@ FYI
+danakj@ for review

It seems like we should be able to easily profile any test without manually
turning on profiling for each. Now you just need to specify enable_profiling in
gn args.

[danakj, 2016-07-08 20:46:32]

LGTM

[Fady Samuel, 2016-07-08 20:54:50]

fsamuel@chromium.org changed reviewers:
+ sky@chromium.org

[Fady Samuel, 2016-07-08 20:54:50]

+sky@ for added include in profiling.cc (I'm TBR'ing you), the switches change
looks like a free-for-all:
https://cs.chromium.org/chromium/src/chrome/common/OWNERS?l=1

[Fady Samuel, 2016-07-08 20:55:03]

Description was changed from

==========
Make all tests profilable

We did not run profiling on unit and perf tests even when the
enable_profiling build flag was present. In order to dump profiling data,
base::debug::StartProfiling(..) must be called somewhere. I've moved that
code to base::TestSuite. Note that this code is a no-op unless the profiling
build flag is present.

BUG=624459
==========

to

==========
Make all tests profilable

We did not run profiling on unit and perf tests even when the
enable_profiling build flag was present. In order to dump profiling data,
base::debug::StartProfiling(..) must be called somewhere. I've moved that
code to base::TestSuite. Note that this code is a no-op unless the profiling
build flag is present.

BUG=624459
TBR=sky@chromium.org
==========

[Fady Samuel, 2016-07-08 20:56:31]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2016-07-08 20:56:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-07-08 20:57:53]

LGTM

[commit-bot: I haz the power, 2016-07-08 23:02:56]

Description was changed from

==========
Make all tests profilable

We did not run profiling on unit and perf tests even when the
enable_profiling build flag was present. In order to dump profiling data,
base::debug::StartProfiling(..) must be called somewhere. I've moved that
code to base::TestSuite. Note that this code is a no-op unless the profiling
build flag is present.

BUG=624459
TBR=sky@chromium.org
==========

to

==========
Make all tests profilable

We did not run profiling on unit and perf tests even when the
enable_profiling build flag was present. In order to dump profiling data,
base::debug::StartProfiling(..) must be called somewhere. I've moved that
code to base::TestSuite. Note that this code is a no-op unless the profiling
build flag is present.

BUG=624459
TBR=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-07-08 23:02:57]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-08 23:03:10]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-08 23:04:08]

Description was changed from

==========
Make all tests profilable

We did not run profiling on unit and perf tests even when the
enable_profiling build flag was present. In order to dump profiling data,
base::debug::StartProfiling(..) must be called somewhere. I've moved that
code to base::TestSuite. Note that this code is a no-op unless the profiling
build flag is present.

BUG=624459
TBR=sky@chromium.org
==========

to

==========
Make all tests profilable

We did not run profiling on unit and perf tests even when the
enable_profiling build flag was present. In order to dump profiling data,
base::debug::StartProfiling(..) must be called somewhere. I've moved that
code to base::TestSuite. Note that this code is a no-op unless the profiling
build flag is present.

BUG=624459
TBR=sky@chromium.org

Committed: https://crrev.com/2573dfb1ec3c99ab6d7c1863b8e6a7a24f4fe626
Cr-Commit-Position: refs/heads/master@{#404522}
==========

[commit-bot: I haz the power, 2016-07-08 23:04:09]

Patchset 1 (id:??) landed as
https://crrev.com/2573dfb1ec3c99ab6d7c1863b8e6a7a24f4fe626
Cr-Commit-Position: refs/heads/master@{#404522}