Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1151)

Side by Side Diff: chrome/browser/chrome_browser_main.cc

Issue 2131233002: Put STHSet component behind a base::Feature. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/common/chrome_features.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chrome_browser_main.h" 5 #include "chrome/browser/chrome_browser_main.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <set> 10 #include <set>
(...skipping 479 matching lines...) Expand 10 before | Expand all | Expand 10 after
490 #elif !defined(OS_CHROMEOS) 490 #elif !defined(OS_CHROMEOS)
491 // CRLSetFetcher attempts to load a CRL set from either the local disk or 491 // CRLSetFetcher attempts to load a CRL set from either the local disk or
492 // network. 492 // network.
493 // For Chrome OS this registration is delayed until user login. 493 // For Chrome OS this registration is delayed until user login.
494 g_browser_process->crl_set_fetcher()->StartInitialLoad(cus, path); 494 g_browser_process->crl_set_fetcher()->StartInitialLoad(cus, path);
495 // Registration of the EV Whitelist component here is not necessary for: 495 // Registration of the EV Whitelist component here is not necessary for:
496 // 1. Android: Because it currently does not have the EV indicator. 496 // 1. Android: Because it currently does not have the EV indicator.
497 // 2. Chrome OS: On Chrome OS this registration is delayed until user login. 497 // 2. Chrome OS: On Chrome OS this registration is delayed until user login.
498 RegisterEVWhitelistComponent(cus, path); 498 RegisterEVWhitelistComponent(cus, path);
499 499
500 // Registration of the STH set fetcher here is not done for: 500 if (base::FeatureList::IsEnabled(features::kSTHSetComponent)) {
Eran Messeri 2016/07/08 15:39:36 Please document the experiment / link to a bug.
Alexei Svitkine (slow) 2016/07/08 15:42:15 Done.
501 // Android: Because the story around CT on Mobile is not finalized yet. 501 // Registration of the STH set fetcher here is not done for:
502 // Chrome OS: On Chrome OS this registration is delayed until user login. 502 // Android: Because the story around CT on Mobile is not finalized yet.
503 RegisterSTHSetComponent(cus, path); 503 // Chrome OS: On Chrome OS this registration is delayed until user login.
504 RegisterSTHSetComponent(cus, path);
505 }
504 #endif // defined(OS_ANDROID) 506 #endif // defined(OS_ANDROID)
505 RegisterOriginTrialsComponent(cus, path); 507 RegisterOriginTrialsComponent(cus, path);
506 508
507 RegisterFileTypePoliciesComponent(cus, path); 509 RegisterFileTypePoliciesComponent(cus, path);
508 } 510 }
509 511
510 #if defined(OS_WIN) 512 #if defined(OS_WIN)
511 #if defined(GOOGLE_CHROME_BUILD) 513 #if defined(GOOGLE_CHROME_BUILD)
512 RegisterSwReporterComponent(cus); 514 RegisterSwReporterComponent(cus);
513 #endif // defined(GOOGLE_CHROME_BUILD) 515 #endif // defined(GOOGLE_CHROME_BUILD)
(...skipping 1520 matching lines...) Expand 10 before | Expand all | Expand 10 after
2034 chromeos::CrosSettings::Shutdown(); 2036 chromeos::CrosSettings::Shutdown();
2035 #endif // defined(OS_CHROMEOS) 2037 #endif // defined(OS_CHROMEOS)
2036 #endif // defined(OS_ANDROID) 2038 #endif // defined(OS_ANDROID)
2037 } 2039 }
2038 2040
2039 // Public members: 2041 // Public members:
2040 2042
2041 void ChromeBrowserMainParts::AddParts(ChromeBrowserMainExtraParts* parts) { 2043 void ChromeBrowserMainParts::AddParts(ChromeBrowserMainExtraParts* parts) {
2042 chrome_extra_parts_.push_back(parts); 2044 chrome_extra_parts_.push_back(parts);
2043 } 2045 }
OLDNEW
« no previous file with comments | « no previous file | chrome/common/chrome_features.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698