content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 213123011: Make DeviceDisplayInfo a Singleton and have ScreenOrientationListener update it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 213123011: Make DeviceDisplayInfo a Singleton and have ScreenOrientationListener update it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java ('k') | content/public/android/java/src/org/chromium/content/browser/ScreenOrientationListener.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index 93e74bca72eae77901608c0374a964572c223d0e..a6251b81dadae71c33a04dd053e8784dd4a1a72e 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -539,7 +539,7 @@ public class ContentViewCore

View view, float x, float y, float width, float height) {

assert view.getParent() == mContainerView;

- float scale = (float) DeviceDisplayInfo.create(getContext()).getDIPScale();

+ float scale = (float) DeviceDisplayInfo.getInstance(getContext()).getDIPScale();

// The anchor view should not go outside the bounds of the ContainerView.

int leftMargin = Math.round(x * scale);