src/sksl/ir/SkSLFloatLiteral.h - Issue 2131223002: SkSL performance improvements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/sksl/ir/SkSLFloatLiteral.h

Issue 2131223002: SkSL performance improvements (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: went back to pointers on global types Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/sksl/ir/SkSLFloatLiteral.h

diff --git a/src/sksl/ir/SkSLFloatLiteral.h b/src/sksl/ir/SkSLFloatLiteral.h

index deb5b2714418ff343bebff362b095d5747665afa..8f5ec43299543976969ed037caeb337a600b4b4c 100644

--- a/src/sksl/ir/SkSLFloatLiteral.h

+++ b/src/sksl/ir/SkSLFloatLiteral.h

@@ -17,7 +17,7 @@ namespace SkSL {

struct FloatLiteral : public Expression {

FloatLiteral(Position position, double value)

- : INHERITED(position, kFloatLiteral_Kind, kFloat_Type)

+ : INHERITED(position, kFloatLiteral_Kind, *kFloat_Type)

, fValue(value) {}

virtual std::string description() const override {