Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Side by Side Diff: src/sksl/ir/SkSLTypeReference.h

Issue 2131223002: SkSL performance improvements (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: went back to pointers on global types Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2016 Google Inc. 2 * Copyright 2016 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef SKSL_TYPEREFERENCE 8 #ifndef SKSL_TYPEREFERENCE
9 #define SKSL_TYPEREFERENCE 9 #define SKSL_TYPEREFERENCE
10 10
11 #include "SkSLExpression.h" 11 #include "SkSLExpression.h"
12 12
13 namespace SkSL { 13 namespace SkSL {
14 14
15 /** 15 /**
16 * Represents an identifier referring to a type. This is an intermediate value: TypeReferences are 16 * Represents an identifier referring to a type. This is an intermediate value: TypeReferences are
17 * always eventually replaced by Constructors in valid programs. 17 * always eventually replaced by Constructors in valid programs.
18 */ 18 */
19 struct TypeReference : public Expression { 19 struct TypeReference : public Expression {
20 TypeReference(Position position, std::shared_ptr<Type> type) 20 TypeReference(Position position, const Type& type)
21 : INHERITED(position, kTypeReference_Kind, kInvalid_Type) 21 : INHERITED(position, kTypeReference_Kind, *kInvalid_Type)
22 , fValue(std::move(type)) {} 22 , fValue(type) {}
23 23
24 std::string description() const override { 24 std::string description() const override {
25 ASSERT(false); 25 ASSERT(false);
26 return "<type>"; 26 return "<type>";
27 } 27 }
28 28
29 const std::shared_ptr<Type> fValue; 29 const Type& fValue;
30 30
31 typedef Expression INHERITED; 31 typedef Expression INHERITED;
32 }; 32 };
33 33
34 } // namespace 34 } // namespace
35 35
36 #endif 36 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698