Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: src/sksl/ir/SkSLFunctionDeclaration.h

Issue 2131223002: SkSL performance improvements (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: fixed windows build error Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2016 Google Inc. 2 * Copyright 2016 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef SKSL_FUNCTIONDECLARATION 8 #ifndef SKSL_FUNCTIONDECLARATION
9 #define SKSL_FUNCTIONDECLARATION 9 #define SKSL_FUNCTIONDECLARATION
10 10
11 #include "SkSLModifiers.h" 11 #include "SkSLModifiers.h"
12 #include "SkSLSymbol.h" 12 #include "SkSLSymbol.h"
13 #include "SkSLSymbolTable.h"
13 #include "SkSLType.h" 14 #include "SkSLType.h"
14 #include "SkSLVariable.h" 15 #include "SkSLVariable.h"
15 16
16 namespace SkSL { 17 namespace SkSL {
17 18
18 /** 19 /**
19 * A function declaration (not a definition -- does not contain a body). 20 * A function declaration (not a definition -- does not contain a body).
20 */ 21 */
21 struct FunctionDeclaration : public Symbol { 22 struct FunctionDeclaration : public Symbol {
22 FunctionDeclaration(Position position, std::string name, 23 FunctionDeclaration(Position position, std::string name,
23 std::vector<std::shared_ptr<Variable>> parameters, 24 std::vector<const Variable*> parameters, const Type& ret urnType,
24 std::shared_ptr<Type> returnType) 25 std::shared_ptr<SymbolTable> symbols)
25 : INHERITED(position, kFunctionDeclaration_Kind, std::move(name)) 26 : INHERITED(position, kFunctionDeclaration_Kind, std::move(name))
26 , fDefined(false) 27 , fDefined(false)
27 , fParameters(parameters) 28 , fParameters(std::move(parameters))
28 , fReturnType(returnType) {} 29 , fReturnType(returnType)
30 , fSymbols(std::move(symbols)) {}
29 31
30 std::string description() const override { 32 std::string description() const override {
31 std::string result = fReturnType->description() + " " + fName + "("; 33 std::string result = fReturnType.description() + " " + fName + "(";
32 std::string separator = ""; 34 std::string separator = "";
33 for (auto p : fParameters) { 35 for (auto p : fParameters) {
34 result += separator; 36 result += separator;
35 separator = ", "; 37 separator = ", ";
36 result += p->description(); 38 result += p->description();
37 } 39 }
38 result += ")"; 40 result += ")";
39 return result; 41 return result;
40 } 42 }
41 43
42 bool matches(FunctionDeclaration& f) { 44 bool matches(const FunctionDeclaration& f) const {
43 return fName == f.fName && fParameters == f.fParameters; 45 if (fName != f.fName) {
46 return false;
47 }
48 if (fParameters.size() != f.fParameters.size()) {
49 return false;
50 }
51 for (size_t i = 0; i < fParameters.size(); i++) {
52 if (fParameters[i]->fType != f.fParameters[i]->fType) {
53 return false;
54 }
55 }
56 return true;
44 } 57 }
45 58
46 mutable bool fDefined; 59 mutable bool fDefined;
47 const std::vector<std::shared_ptr<Variable>> fParameters; 60 const std::vector<const Variable*> fParameters;
48 const std::shared_ptr<Type> fReturnType; 61 const Type& fReturnType;
62 const std::shared_ptr<SymbolTable> fSymbols;
49 63
50 typedef Symbol INHERITED; 64 typedef Symbol INHERITED;
51 }; 65 };
52 66
53 } // namespace 67 } // namespace
54 68
55 #endif 69 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698