Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 2131163002: [mojo] Add shared buffer support to mojo JavaScript bindings. (Closed)

Created:
4 years, 5 months ago by shalamov
Modified:
4 years, 4 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo] Add shared buffer support to mojo JavaScript bindings. This patch adds shared buffer support to mojo JavaScript bindings. Tests are updated to verify new functionality. Added functions: core.createSharedBuffer core.duplicateBufferHandle core.mapBuffer core.unmapBuffer BUG=606766 Committed: https://crrev.com/74075f4538e5ca250ab1dac556bb9ef4fcdbc9af Cr-Commit-Position: refs/heads/master@{#409170}

Patch Set 1 : [mojo] Add shared buffer support to mojo JavaScript bindings. #

Patch Set 2 : Initialize options.struct_size #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -0 lines) Patch
M mojo/edk/js/core.cc View 1 3 chunks +91 lines, -0 lines 0 comments Download
M mojo/public/js/core.js View 1 2 chunks +75 lines, -0 lines 0 comments Download
M mojo/public/js/core_unittests.js View 1 3 chunks +48 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
shalamov
Ken, could you please take a look? We need this functionality to implement mock Sensor ...
4 years, 5 months ago (2016-07-08 12:04:39 UTC) #3
Ken Rockot(use gerrit already)
This is great, thanks. LGTM
4 years, 5 months ago (2016-07-08 16:28:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131163002/20001
4 years, 5 months ago (2016-07-13 07:48:31 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/261893)
4 years, 5 months ago (2016-07-13 09:04:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131163002/40001
4 years, 4 months ago (2016-08-02 11:03:58 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 4 months ago (2016-08-02 11:07:04 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 11:09:04 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/74075f4538e5ca250ab1dac556bb9ef4fcdbc9af
Cr-Commit-Position: refs/heads/master@{#409170}

Powered by Google App Engine
This is Rietveld 408576698