Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2131143002: cc: Modify visible geometry rect calc while appending quads.

Created:
4 years, 5 months ago by sohanjg
Modified:
4 years, 5 months ago
Reviewers:
danakj, vmiura, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Modify visible geometry rect calc while appending quads. This takes the visible geometry rect calc to layer space. While appending quads an intersection is performed with quad geometry rect to obtain the visible rect per quad. BUG=623198 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -18 lines) Patch
M cc/layers/picture_layer_impl.cc View 10 chunks +25 lines, -18 lines 1 comment Download

Messages

Total messages: 6 (3 generated)
sohanjg
This fails the (PictureLayerImplTest, Occlusion) test though, i will check it, if this is in ...
4 years, 5 months ago (2016-07-08 10:42:56 UTC) #3
enne (OOO)
This looks reasonable to me. There's some slight trade off that we'll get less occlusion ...
4 years, 5 months ago (2016-07-08 17:58:55 UTC) #5
sohanjg
4 years, 5 months ago (2016-07-12 10:57:16 UTC) #6
On 2016/07/08 17:58:55, enne wrote:
> This looks reasonable to me.  There's some slight trade off that we'll get
less
> occlusion in some cases where the occlusion is not axis aligned, but I think
> that's ok.  So, fix up the occlusion test, and let's land this.  Thanks!
> 
>
https://codereview.chromium.org/2131143002/diff/1/cc/layers/picture_layer_imp...
> File cc/layers/picture_layer_impl.cc (right):
> 
>
https://codereview.chromium.org/2131143002/diff/1/cc/layers/picture_layer_imp...
> cc/layers/picture_layer_impl.cc:182: gfx::Rect visible_geometry_rect =
> Maybe an early out here if visible geometry rect is empty too?

There is some change in behavior for partial occlusion.
https://cs.chromium.org/chromium/src/cc/layers/picture_layer_impl_unittest.cc...

For, the given occluded rect, the quads visible and geometry rect are coming as
same in some cases, even though the target and occluded rects intersect.
So, the verifyquads test fails here, 
https://cs.chromium.org/chromium/src/cc/test/layer_test_common.cc?q=LayerTest...

Can you please suggest whats the best way ahead ? thanks.

Powered by Google App Engine
This is Rietveld 408576698