cc: Modify visible geometry rect calc while appending quads.

cc: Modify visible geometry rect calc while  appending quads.

This takes the visible geometry rect calc to layer space. While appending quads
an intersection is performed with quad geometry rect to obtain the visible rect
per quad.

BUG=623198
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

[sohanjg, 2016-07-08 10:07:26]

Description was changed from

==========
cc: Modify visible geometry rect calc while  appending quads.

This takes the visible geometry rect calc to layer space.
While appending quads, an intersection is performed with quad geometry rect to
obtain the visible rect per quad.

BUG=623198
==========

to

==========
cc: Modify visible geometry rect calc while  appending quads.

This takes the visible geometry rect calc to layer space.
While appending quads, an intersection is performed with quad geometry rect to
obtain the visible rect per quad.

BUG=623198
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[sohanjg, 2016-07-08 10:42:55]

sohan.jyoti@samsung.com changed reviewers:
+ danakj@chromium.org, enne@chromium.org, vmiura@chromium.org

[sohanjg, 2016-07-08 10:42:56]

This fails the (PictureLayerImplTest, Occlusion) test though, i will check it,
if this is in the right direction. thanks.

[sohanjg, 2016-07-08 10:46:18]

Description was changed from

==========
cc: Modify visible geometry rect calc while  appending quads.

This takes the visible geometry rect calc to layer space.
While appending quads, an intersection is performed with quad geometry rect to
obtain the visible rect per quad.

BUG=623198
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Modify visible geometry rect calc while  appending quads.

This takes the visible geometry rect calc to layer space. While appending quads
an intersection is performed with quad geometry rect to obtain the visible rect
per quad.

BUG=623198
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[enne (OOO), 2016-07-08 17:58:55]

This looks reasonable to me.  There's some slight trade off that we'll get less
occlusion in some cases where the occlusion is not axis aligned, but I think
that's ok.  So, fix up the occlusion test, and let's land this.  Thanks!

https://codereview.chromium.org/2131143002/diff/1/cc/layers/picture_layer_imp...
File cc/layers/picture_layer_impl.cc (right):

https://codereview.chromium.org/2131143002/diff/1/cc/layers/picture_layer_imp...
cc/layers/picture_layer_impl.cc:182: gfx::Rect visible_geometry_rect =
Maybe an early out here if visible geometry rect is empty too?

[sohanjg, 2016-07-12 10:57:16]

On 2016/07/08 17:58:55, enne wrote:
> This looks reasonable to me.  There's some slight trade off that we'll get
less
> occlusion in some cases where the occlusion is not axis aligned, but I think
> that's ok.  So, fix up the occlusion test, and let's land this.  Thanks!
> 
>
https://codereview.chromium.org/2131143002/diff/1/cc/layers/picture_layer_imp...
> File cc/layers/picture_layer_impl.cc (right):
> 
>
https://codereview.chromium.org/2131143002/diff/1/cc/layers/picture_layer_imp...
> cc/layers/picture_layer_impl.cc:182: gfx::Rect visible_geometry_rect =
> Maybe an early out here if visible geometry rect is empty too?

There is some change in behavior for partial occlusion.
https://cs.chromium.org/chromium/src/cc/layers/picture_layer_impl_unittest.cc...

For, the given occluded rect, the quads visible and geometry rect are coming as
same in some cases, even though the target and occluded rects intersect.
So, the verifyquads test fails here, 
https://cs.chromium.org/chromium/src/cc/test/layer_test_common.cc?q=LayerTest...

Can you please suggest whats the best way ahead ? thanks.