Remove web_app_ui.[cc|h].

Remove web_app_ui.[cc|h].

The UpdateShortcutWorker class is windows specific and is moved to its own file.

UpdateShortcutForTabContents is moved to web_app_win.

GetShortcutInfoForTab is moved to web_app.

TBR=sky@chromium.org
BUG=356889
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261481

[benwells, 2014-03-28 02:55:25]

https://codereview.chromium.org/213113005/diff/30001/chrome/browser/extension...
File chrome/browser/extensions/tab_helper.cc (right):

https://codereview.chromium.org/213113005/diff/30001/chrome/browser/extension...
chrome/browser/extensions/tab_helper.cc:355: #if defined(OS_WIN)
I'd prefer to keep the #if in web app code.

That is, in web_app.cc have an empty implementation of this, guarded in #if
!defined(OS_WIN)

https://codereview.chromium.org/213113005/diff/30001/chrome/browser/web_appli...
File chrome/browser/web_applications/web_app.cc (right):

https://codereview.chromium.org/213113005/diff/30001/chrome/browser/web_appli...
chrome/browser/web_applications/web_app.cc:152:
(web_contents->GetTitle().empty() ? base::UTF8ToUTF16(info->url.spec()) :
Is this clang format?

[jackhou1, 2014-04-02 03:25:56]

https://codereview.chromium.org/213113005/diff/30001/chrome/browser/extension...
File chrome/browser/extensions/tab_helper.cc (right):

https://codereview.chromium.org/213113005/diff/30001/chrome/browser/extension...
chrome/browser/extensions/tab_helper.cc:355: #if defined(OS_WIN)
On 2014/03/28 02:55:26, benwells wrote:
> I'd prefer to keep the #if in web app code.
> 
> That is, in web_app.cc have an empty implementation of this, guarded in #if
> !defined(OS_WIN)

Done.

https://codereview.chromium.org/213113005/diff/30001/chrome/browser/web_appli...
File chrome/browser/web_applications/web_app.cc (right):

https://codereview.chromium.org/213113005/diff/30001/chrome/browser/web_appli...
chrome/browser/web_applications/web_app.cc:152:
(web_contents->GetTitle().empty() ? base::UTF8ToUTF16(info->url.spec()) :
On 2014/03/28 02:55:26, benwells wrote:
> Is this clang format?

This is just copied directly from web_app_ui.cc. I'd prefer not to change it.

git cl format actually uses operators-on-new-line:
i.e. condition 
    ? result
    : alternative;

but chromium code typically uses outputs-on-new-line:
i.e. condition ?
    result : alternative;

[benwells, 2014-04-02 06:39:30]

lgtm

[jackhou1, 2014-04-02 06:47:36]

sky, please review for OWNERS in:

chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.cc
chrome/browser/ui/views/create_application_shortcut_view.cc

(just a couple of #includes)

[jackhou1, 2014-04-02 06:52:27]

benwells mentioned this is probably TBR-able, so, into the CQ!

[jackhou1, 2014-04-02 06:52:32]

The CQ bit was checked by jackhou@chromium.org

[commit-bot: I haz the power, 2014-04-02 06:53:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jackhou@chromium.org/213113005/70001

[commit-bot: I haz the power, 2014-04-02 10:58:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-02 10:58:41]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel
  tryserver.chromium on linux_chromium_rel

[jackhou1, 2014-04-02 23:06:44]

The CQ bit was checked by jackhou@chromium.org

[commit-bot: I haz the power, 2014-04-02 23:08:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jackhou@chromium.org/213113005/70001

[commit-bot: I haz the power, 2014-04-03 07:23:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-03 07:23:27]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[jackhou1, 2014-04-03 15:43:03]

The CQ bit was checked by jackhou@chromium.org

[commit-bot: I haz the power, 2014-04-03 15:43:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jackhou@chromium.org/213113005/70001

[commit-bot: I haz the power, 2014-04-03 18:18:07]

Change committed as 261481