Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2131113002: Make CompositeEditCommand::moveParagraph() to abort when destination becomes invisible (Closed)

Created:
4 years, 5 months ago by yosin_UTC9
Modified:
4 years, 5 months ago
Reviewers:
yoichio
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make CompositeEditCommand::moveParagraph() to abort when destination becomes invisible This patch makes |CompositeEditCommand::moveParagraph()| to abort when destination of paragraph becomes invisible. This patch also changes |assert_selection()| test utility to handle no BODY element document to support attached test. BUG=620873 TEST=LayoutTests/editing/execCommand/apply_style/justify_full_without_body_crash.html Committed: https://crrev.com/1657802d64c2945eae971ca90bbb33a9e48f5026 Cr-Commit-Position: refs/heads/master@{#406738}

Patch Set 1 : 2016-07-08T16:32:15 #

Patch Set 2 : 2016-07-15T17:33:59 #

Patch Set 3 : 2016-07-20T17:11:32 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/editing/execCommand/apply_style/justify_full_without_body_crash.html View 1 chunk +32 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 1 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
yosin_UTC9
PTAL
4 years, 5 months ago (2016-07-20 01:37:06 UTC) #8
yoichio
Please make another CL to change asset_selection.js and add test for it.
4 years, 5 months ago (2016-07-20 02:02:33 UTC) #9
yosin_UTC9
PTAL Move assert_selection.js changes to another CL.
4 years, 5 months ago (2016-07-20 08:21:55 UTC) #12
yoichio
lgtm
4 years, 5 months ago (2016-07-20 09:03:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131113002/40001
4 years, 5 months ago (2016-07-21 01:20:35 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-21 01:26:01 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 01:28:39 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1657802d64c2945eae971ca90bbb33a9e48f5026
Cr-Commit-Position: refs/heads/master@{#406738}

Powered by Google App Engine
This is Rietveld 408576698