Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2131103003:
cc: Do not use deadline state for scheduler unittests. (Closed)
|
Created:
4 years, 5 months ago by sunnyps Modified:
4 years, 5 months ago Reviewers:
brianderson CC:
chromium-reviews, cc-bugs_chromium.org, scheduler-bugs_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptioncc: Do not use deadline state for scheduler unittests.
Scheduler unittests should not rely on the deadline state which is an
internal implementation detail of the scheduler. Checking the state from
the perspective of the client is better. This is a prerequisite for
refactoring the deadline logic in the scheduler and removing retro
frames.
R=brianderson@chromium.org
BUG=602485
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
Committed: https://crrev.com/bf10654bfdc17a91703deff61ac808adb18dbf97
Cr-Commit-Position: refs/heads/master@{#405361}
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 29 (14 generated)
Description was changed from ========== cc: Do not use deadline state for scheduler unittests. Scheduler unittests should not rely on the deadline state which is an internal implementation detail of the scheduler. Checking the state from the perspective of the client is better. This is a prerequisite for refactoring the deadline logic in the scheduler and removing retro frames. R=brianderson@chromium.org BUG=602485 ========== to ========== cc: Do not use deadline state for scheduler unittests. Scheduler unittests should not rely on the deadline state which is an internal implementation detail of the scheduler. Checking the state from the perspective of the client is better. This is a prerequisite for refactoring the deadline logic in the scheduler and removing retro frames. R=brianderson@chromium.org BUG=602485 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
PTAL
lgtm
Thanks!
The CQ bit was checked by sunnyps@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by sunnyps@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by sunnyps@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sunnyps@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Your CL relies on deprecated CQ feature(s): * Specifying master names without "master." prefix is deprecated: tryserver.blink. For more details, see http://crbug.com/617627.
Description was changed from ========== cc: Do not use deadline state for scheduler unittests. Scheduler unittests should not rely on the deadline state which is an internal implementation detail of the scheduler. Checking the state from the perspective of the client is better. This is a prerequisite for refactoring the deadline logic in the scheduler and removing retro frames. R=brianderson@chromium.org BUG=602485 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== cc: Do not use deadline state for scheduler unittests. Scheduler unittests should not rely on the deadline state which is an internal implementation detail of the scheduler. Checking the state from the perspective of the client is better. This is a prerequisite for refactoring the deadline logic in the scheduler and removing retro frames. R=brianderson@chromium.org BUG=602485 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel ==========
The CQ bit was unchecked by sunnyps@chromium.org
The CQ bit was checked by sunnyps@chromium.org
The CQ bit was checked by sunnyps@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== cc: Do not use deadline state for scheduler unittests. Scheduler unittests should not rely on the deadline state which is an internal implementation detail of the scheduler. Checking the state from the perspective of the client is better. This is a prerequisite for refactoring the deadline logic in the scheduler and removing retro frames. R=brianderson@chromium.org BUG=602485 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel ========== to ========== cc: Do not use deadline state for scheduler unittests. Scheduler unittests should not rely on the deadline state which is an internal implementation detail of the scheduler. Checking the state from the perspective of the client is better. This is a prerequisite for refactoring the deadline logic in the scheduler and removing retro frames. R=brianderson@chromium.org BUG=602485 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== cc: Do not use deadline state for scheduler unittests. Scheduler unittests should not rely on the deadline state which is an internal implementation detail of the scheduler. Checking the state from the perspective of the client is better. This is a prerequisite for refactoring the deadline logic in the scheduler and removing retro frames. R=brianderson@chromium.org BUG=602485 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel ========== to ========== cc: Do not use deadline state for scheduler unittests. Scheduler unittests should not rely on the deadline state which is an internal implementation detail of the scheduler. Checking the state from the perspective of the client is better. This is a prerequisite for refactoring the deadline logic in the scheduler and removing retro frames. R=brianderson@chromium.org BUG=602485 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel Committed: https://crrev.com/bf10654bfdc17a91703deff61ac808adb18dbf97 Cr-Commit-Position: refs/heads/master@{#405361} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/bf10654bfdc17a91703deff61ac808adb18dbf97 Cr-Commit-Position: refs/heads/master@{#405361} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
