third_party/WebKit/Source/core/editing/iterators/TextIterator.h - Issue 2131103002: Ensure that TextIterator::m_pastEndNode is not skipped in advance()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/iterators/TextIterator.h

Issue 2131103002: Ensure that TextIterator::m_pastEndNode is not skipped in advance() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revise unit test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/editing/iterators/TextIterator.h

diff --git a/third_party/WebKit/Source/core/editing/iterators/TextIterator.h b/third_party/WebKit/Source/core/editing/iterators/TextIterator.h

index 5845bb3464dce3f15e1168721bdd949de44878e8..b875f3eef525f6c902a04168dd801b220d12946f 100644

--- a/third_party/WebKit/Source/core/editing/iterators/TextIterator.h

+++ b/third_party/WebKit/Source/core/editing/iterators/TextIterator.h

@@ -168,6 +168,9 @@ private:

int m_startOffset;

Member<Node> m_endContainer;

int m_endOffset;

+ // |m_endNode| stores |Strategy::childAt(*m_endContainer, m_endOffset - 1)|,

+ // if it exists, or |nullptr| otherwise.

+ Member<Node> m_endNode;

Member<Node> m_pastEndNode;

// Used when there is still some pending text from the current node; when these

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp » ('j') | no next file with comments »