Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2131083002: More Mac CQ builder adjusting. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

More Mac CQ builder adjusting. This CL takes mac_chromium_gyp_rel out of the CQ altogether, and drops mac_chromium_10.10_rel_ng to a 50% experiment to help it get caught up. TBR=kbr@chromium.org NOTRY=true BUG=626492 Committed: https://crrev.com/12b791371788f449ff3782d4707992f3a017a2f7 Cr-Commit-Position: refs/heads/master@{#404361}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M infra/config/cq.cfg View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Dirk Pranke
4 years, 5 months ago (2016-07-08 03:09:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131083002/1
4 years, 5 months ago (2016-07-08 03:09:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 14:14:55 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/12b791371788f449ff3782d4707992f3a017a2f7 Cr-Commit-Position: refs/heads/master@{#404361}
4 years, 5 months ago (2016-07-08 14:17:56 UTC) #6
Ken Russell (switch to Gerrit)
LGTM, but the new slaves in https://codereview.chromium.org/2133863003 are needed. Currently this pool has 5 slaves; ...
4 years, 5 months ago (2016-07-08 22:33:17 UTC) #7
Dirk Pranke
On 2016/07/08 22:33:17, Ken Russell wrote: > LGTM, but the new slaves in https://codereview.chromium.org/2133863003 are ...
4 years, 5 months ago (2016-07-09 00:37:57 UTC) #8
Ken Russell (switch to Gerrit)
4 years, 5 months ago (2016-07-09 01:35:10 UTC) #9
Message was sent while issue was closed.
On 2016/07/09 00:37:57, Dirk Pranke wrote:
> On 2016/07/08 22:33:17, Ken Russell wrote:
> > LGTM, but the new slaves in https://codereview.chromium.org/2133863003 are
> > needed. Currently this pool has 5 slaves; the main pool has 90. Any
experiment
> > over 5% in my opinion runs the risk of swamping the optional slaves.
> 
> I'm not sure how this is related to the other CL. In this case, this takes the
> builder
> that uses the optional pool out of the CQ entirely, and the 10.10 builder uses
> a completely different pool.

Ah, sorry, I thought they were in the same pool. Agreed, they're unrelated.

> I actually don't think we should put any experimental builder into an optional
> pool
> at all; I think builders should be moved to the main pools before they are
added
> as experiments (and it was a mistake that I didn't do this for
> mac_chromium_gyp_rel).

Agreed.

Powered by Google App Engine
This is Rietveld 408576698