third_party/WebKit/Source/core/html/forms/OptionList.cpp - Issue 2131073002: SELECT element: Avoid to use listItems() in HTMLSelectElement::selectOption()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/OptionList.cpp

Issue 2131073002: SELECT element: Avoid to use listItems() in HTMLSelectElement::selectOption() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/forms/OptionList.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/OptionList.cpp b/third_party/WebKit/Source/core/html/forms/OptionList.cpp

index 06f4f6fe6cef9715d830be5e4e85c81303e910bf..5cdd19aac1115f1d437151385b00c962625dd17d 100644

--- a/third_party/WebKit/Source/core/html/forms/OptionList.cpp

+++ b/third_party/WebKit/Source/core/html/forms/OptionList.cpp

@@ -28,7 +28,7 @@ void OptionListIterator::advance(HTMLOptionElement* previous)

m_current = toHTMLOptionElement(current);

return;

}

- if (isHTMLOptGroupElement(current) && current->parentNode() == m_select) {

+ if (isHTMLOptGroupElement(current) && current->parentNode() == m_select.get()) {

if ((m_current = Traversal<HTMLOptionElement>::firstChild(*current)))

return;

}

« third_party/WebKit/Source/core/html/HTMLSelectElement.cpp ('K') | « third_party/WebKit/Source/core/html/forms/OptionList.h ('k') | no next file » | no next file with comments »