Source/core/rendering/RenderObject.h - Issue 213103003: Optimize repaint on FrameView resize

Unified Diff: Source/core/rendering/RenderObject.h

Issue 213103003: Optimize repaint on FrameView resize (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Actual parameters Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderObject.h

diff --git a/Source/core/rendering/RenderObject.h b/Source/core/rendering/RenderObject.h

index 7ffb86cf19aca82d227df40ec668be67628ae97a..06740b10e4babaa348bf19a5394530f590873608 100644

--- a/Source/core/rendering/RenderObject.h

+++ b/Source/core/rendering/RenderObject.h

@@ -611,7 +611,7 @@ public:

Element* offsetParent() const;

void markContainingBlocksForLayout(bool scheduleRelayout = true, RenderObject* newRoot = 0, SubtreeLayoutScope* = 0);

- void setNeedsLayout(MarkingBehavior = MarkContainingBlockChain, SubtreeLayoutScope* = 0);

+ void setNeedsLayout(MarkingBehavior = MarkContainingBlockChain, SubtreeLayoutScope* = 0, bool fullRepaintLayer = true);

ojan 2014/03/28 01:51:36 We typically don't do booleans like this. This sho

Xianzhu 2014/03/28 16:26:01 Done.

void clearNeedsLayout();

void setChildNeedsLayout(MarkingBehavior = MarkContainingBlockChain, SubtreeLayoutScope* = 0);

void setNeedsPositionedMovementLayout();

@@ -1269,7 +1269,7 @@ inline bool RenderObject::isBeforeOrAfterContent() const

return isBeforeContent() || isAfterContent();

}

-inline void RenderObject::setNeedsLayout(MarkingBehavior markParents, SubtreeLayoutScope* layouter)

+inline void RenderObject::setNeedsLayout(MarkingBehavior markParents, SubtreeLayoutScope* layouter, bool fullRepaintLayer)

{

ASSERT(!isSetNeedsLayoutForbidden());

bool alreadyNeededLayout = m_bitfields.selfNeedsLayout();

@@ -1277,7 +1277,7 @@ inline void RenderObject::setNeedsLayout(MarkingBehavior markParents, SubtreeLay

if (!alreadyNeededLayout) {

if (markParents == MarkContainingBlockChain && (!layouter || layouter->root() != this))

markContainingBlocksForLayout(true, 0, layouter);

- if (hasLayer())

+ if (fullRepaintLayer && hasLayer())

setLayerNeedsFullRepaint();

ojan 2014/03/28 01:51:36 Really this code is wrong. I think we should proba

Xianzhu 2014/03/28 16:26:01 Done. trchen@ is working on separating repaint an

}