Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2131013003: Remove dead code webkitpy.common.config.ports_mock. (Closed)

Created:
4 years, 5 months ago by qyearsley
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, dcheng
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dead code webkitpy.common.config.ports_mock. I'm not really sure what "old style Ports" were, but it appears that this section of dead code can be removed quite cleanly. Committed: https://crrev.com/7d8324020ab0e8fd79595726bff4c1be5352972c Cr-Commit-Position: refs/heads/master@{#406883}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -59 lines) Patch
D third_party/WebKit/Tools/Scripts/webkitpy/common/config/ports_mock.py View 1 chunk +0 lines, -51 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/mock_tool.py View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
qyearsley
4 years, 5 months ago (2016-07-08 18:03:41 UTC) #4
dcheng
non-owner LGTM
4 years, 5 months ago (2016-07-12 02:21:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131013003/1
4 years, 5 months ago (2016-07-21 16:05:52 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 17:08:24 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7d8324020ab0e8fd79595726bff4c1be5352972c Cr-Commit-Position: refs/heads/master@{#406883}
4 years, 5 months ago (2016-07-21 17:11:19 UTC) #14
Dirk Pranke
4 years, 4 months ago (2016-08-09 03:45:29 UTC) #15
Message was sent while issue was closed.
old-style ports had to do with this code being used for other ports of webkit.
It's safe to have removed this.

lgtm.

Powered by Google App Engine
This is Rietveld 408576698