Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2130973002: make some canvas utils virtual (for proxy based subclasses) (Closed)

Created:
4 years, 5 months ago by reed1
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

make some canvas utils virtual (for proxy based subclasses) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2130973002 Committed: https://skia.googlesource.com/skia/+/ea5a6513c05e3d7261b68c3ef7d42645ee5bfe17

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M include/core/SkCanvas.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 4 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130973002/1
4 years, 5 months ago (2016-07-07 23:14:30 UTC) #3
reed1
4 years, 5 months ago (2016-07-07 23:15:50 UTC) #5
reed1
4 years, 5 months ago (2016-07-07 23:16:01 UTC) #7
robertphillips
lgtm
4 years, 5 months ago (2016-07-07 23:30:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130973002/1
4 years, 5 months ago (2016-07-07 23:37:46 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 23:44:30 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ea5a6513c05e3d7261b68c3ef7d42645ee5bfe17

Powered by Google App Engine
This is Rietveld 408576698