Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2130953002:
WebView: Immediately ack and return resources for fallback ticks. (Closed)
|
Created:
4 years, 5 months ago by danakj Modified:
4 years, 5 months ago Reviewers:
boliu CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, enne (OOO), piman Base URL:
https://chromium.googlesource.com/chromium/src.git@displaywebview Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionWebView: Immediately ack and return resources for fallback ticks.
R=boliu
BUG=606053
Committed: https://crrev.com/ff780206ab470e7d81df417a082de848a27935b5
Cr-Commit-Position: refs/heads/master@{#404290}
Patch Set 1 #
Total comments: 3
Patch Set 2 : bosthing: . #
Depends on Patchset: Messages
Total messages: 18 (7 generated)
Description was changed from ========== WebView: Immediately ack and return resources for fallback ticks. R=boliu ========== to ========== WebView: Immediately ack and return resources for fallback ticks. R=boliu BUG=606053 ==========
The CQ bit was checked by danakj@chromium.org to run a CQ dry run
Like so?
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
yep, like this https://codereview.chromium.org/2130953002/diff/1/content/renderer/android/sy... File content/renderer/android/synchronous_compositor_output_surface.cc (right): https://codereview.chromium.org/2130953002/diff/1/content/renderer/android/sy... content/renderer/android/synchronous_compositor_output_surface.cc:200: client_->DidSwapBuffers(); sync_client_->SwapBuffers sends the reply of the synchronous IPC to unblock the UI thread, I don't know how expensive DidSwapBuffers, but probably better to not have this here for regular draws. https://codereview.chromium.org/2130953002/diff/1/content/renderer/android/sy... content/renderer/android/synchronous_compositor_output_surface.cc:207: ReturnResources(return_resources); again, can we skip this and just DCHECK there are no resources?
PTAL https://codereview.chromium.org/2130953002/diff/1/content/renderer/android/sy... File content/renderer/android/synchronous_compositor_output_surface.cc (right): https://codereview.chromium.org/2130953002/diff/1/content/renderer/android/sy... content/renderer/android/synchronous_compositor_output_surface.cc:207: ReturnResources(return_resources); On 2016/07/07 21:30:31, boliu wrote: > again, can we skip this and just DCHECK there are no resources? DCHECKing empty, but still sending back the ack to the OutputSurface client.
The CQ bit was checked by danakj@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by danakj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== WebView: Immediately ack and return resources for fallback ticks. R=boliu BUG=606053 ========== to ========== WebView: Immediately ack and return resources for fallback ticks. R=boliu BUG=606053 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== WebView: Immediately ack and return resources for fallback ticks. R=boliu BUG=606053 ========== to ========== WebView: Immediately ack and return resources for fallback ticks. R=boliu BUG=606053 Committed: https://crrev.com/ff780206ab470e7d81df417a082de848a27935b5 Cr-Commit-Position: refs/heads/master@{#404290} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ff780206ab470e7d81df417a082de848a27935b5 Cr-Commit-Position: refs/heads/master@{#404290} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
