Added UMA metrics for display settings UI in the status area.

ash/system/chromeos/tray_display.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/chromeos/tray_display.h"
 
 #include <memory>
 #include <utility>
 #include <vector>
 
+#include "ash/common/metrics/user_metrics_action.h"
 #include "ash/common/system/chromeos/devicetype_utils.h"
 #include "ash/common/system/system_notifier.h"
 #include "ash/common/system/tray/actionable_view.h"
 #include "ash/common/system/tray/fixed_sized_image_view.h"
 #include "ash/common/system/tray/system_tray_delegate.h"
 #include "ash/common/system/tray/tray_constants.h"
 #include "ash/common/system/tray/tray_notification_view.h"
 #include "ash/common/wm_shell.h"
 #include "ash/display/display_manager.h"
 #include "ash/display/screen_orientation_controller_chromeos.h"
@@ skipping 84 matching lines @@
   for (size_t i = 0; i < display_manager->GetNumDisplays(); ++i) {
     int64_t id = display_manager->GetDisplayAt(i).id();
     if (id == internal_id)
       continue;
     lines.push_back(GetDisplayInfoLine(id));
   }
 
   return base::JoinString(lines, base::ASCIIToUTF16("\n"));
 }
 
-void OpenSettings() {
+void OpenSettings(UserMetricsAction action) {

[tdanderson, 2016/07/07 21:41:39]

nit: Add a brief explanation to the documentation of OpenSettings() in the .h to
explain the new parameter

[bruthig, 2016/07/08 17:12:51]

This got reworked a little bit.

   // switch is intentionally introduced without default, to cause an error when
   // a new type of login status is introduced.
   switch (WmShell::Get()->system_tray_delegate()->GetUserLoginStatus()) {
     case LoginStatus::NOT_LOGGED_IN:
     case LoginStatus::LOCKED:
       return;
 
     case LoginStatus::USER:
     case LoginStatus::OWNER:
     case LoginStatus::GUEST:
     case LoginStatus::PUBLIC:
     case LoginStatus::SUPERVISED:
     case LoginStatus::KIOSK_APP:
       SystemTrayDelegate* delegate = WmShell::Get()->system_tray_delegate();
       if (delegate->ShouldShowSettings())
         delegate->ShowDisplaySettings();
   }
+
+  WmShell::Get()->RecordUserMetricsAction(action);
 }
 
 }  // namespace
 
 const char TrayDisplay::kNotificationId[] = "chrome://settings/display";
 
 class DisplayView : public ActionableView {
  public:
   explicit DisplayView() {
     SetLayoutManager(new views::BoxLayout(views::BoxLayout::kHorizontal,
@@ skipping 130 matching lines @@
             (display_info.active_rotation_source() !=
                  display::Display::ROTATION_SOURCE_ACCELEROMETER ||
              !display::Display::IsInternalDisplayId(first_display_id))) ||
            display_info.configured_ui_scale() != 1.0f ||
            !display_info.overscan_insets_in_dip().IsEmpty() ||
            display_info.has_overscan();
   }
 
   // Overridden from ActionableView.
   bool PerformAction(const ui::Event& event) override {
-    OpenSettings();
+    OpenSettings(UMA_STATUS_AREA_DISPLAY_DEFAULT_CLICKED);
     return true;
   }
 
   void OnBoundsChanged(const gfx::Rect& previous_bounds) override {
     int label_max_width = bounds().width() - kTrayPopupPaddingHorizontal * 2 -
                           kTrayPopupPaddingBetweenItems -
                           image_->GetPreferredSize().width();
     label_->SizeToFit(label_max_width);
   }
 
@@ skipping 103 matching lines @@
 
   ui::ResourceBundle& bundle = ui::ResourceBundle::GetSharedInstance();
   std::unique_ptr<Notification> notification(new Notification(
       message_center::NOTIFICATION_TYPE_SIMPLE, kNotificationId, message,
       additional_message, bundle.GetImageNamed(IDR_AURA_NOTIFICATION_DISPLAY),
       base::string16(),  // display_source
       GURL(),
       message_center::NotifierId(message_center::NotifierId::SYSTEM_COMPONENT,
                                  system_notifier::kNotifierDisplay),
       message_center::RichNotificationData(),
-      new message_center::HandleNotificationClickedDelegate(
-          base::Bind(&OpenSettings))));
+      new message_center::HandleNotificationClickedDelegate(base::Bind(
+          &OpenSettings, UMA_STATUS_AREA_DISPLAY_NOTIFICATION_CLICKED))));
 
   message_center::MessageCenter::Get()->AddNotification(
       std::move(notification));
 }
 
 views::View* TrayDisplay::CreateDefaultView(LoginStatus status) {
   DCHECK(default_ == NULL);
   default_ = new DisplayView();
   return default_;
 }
@@ skipping 31 matching lines @@
 bool TrayDisplay::GetAccessibleStateForTesting(ui::AXViewState* state) {
   views::View* view = default_;
   if (view) {
     view->GetAccessibleState(state);
     return true;
   }
   return false;
 }
 
 }  // namespace ash