Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2130913002: Avoid NOTREACHED in content settings bubble. (Closed)

Created:
4 years, 5 months ago by Evan Stade
Modified:
4 years, 5 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid NOTREACHED in content settings bubble. BUG=626337 Committed: https://crrev.com/a9f6881d0c029d165b44a7893eab605f1b7bd046 Cr-Commit-Position: refs/heads/master@{#404538}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/ui/views/content_setting_bubble_contents.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Evan Stade
4 years, 5 months ago (2016-07-08 17:36:04 UTC) #2
msw
lgtm
4 years, 5 months ago (2016-07-08 17:52:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130913002/1
4 years, 5 months ago (2016-07-08 23:49:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 23:53:29 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 23:53:38 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 23:56:30 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9f6881d0c029d165b44a7893eab605f1b7bd046
Cr-Commit-Position: refs/heads/master@{#404538}

Powered by Google App Engine
This is Rietveld 408576698